Skip to content

[compiler] Claude file/settings#351

Closed
everettbu wants to merge 1 commit into
mainfrom
pr35523
Closed

[compiler] Claude file/settings#351
everettbu wants to merge 1 commit into
mainfrom
pr35523

Conversation

@everettbu

@everettbu everettbu commented Jan 16, 2026

Copy link
Copy Markdown

Mirror of facebook/react#35523
Original author: josephsavona


Initializes CLAUDE.md and a settings file for the compiler/ directory to help use claude with the compiler. Note that some of the commands here depend on changes to snap from the next PR.


Stack created with Sapling. Best reviewed with ReviewStack.

  • #35607
  • #35298
  • #35596
  • #35573
  • #35595
  • #35539
  • #35537
  • -> #35523

@everettbu everettbu added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 16, 2026
@everettbu
everettbu force-pushed the pr35523 branch 5 times, most recently from f8e908f to 5cb33f0 Compare January 21, 2026 01:42
Initializes CLAUDE.md and a settings file for the compiler/ directory to help use claude with the compiler. Note that some of the commands here depend on changes to snap from the next PR.
@everettbu
everettbu marked this pull request as ready for review January 22, 2026 23:14
@greptile-apps

greptile-apps Bot commented Jan 22, 2026

Copy link
Copy Markdown

Greptile Summary

Adds Claude Code configuration files to enable AI-assisted development for the React Compiler. Creates comprehensive documentation (CLAUDE.md) covering project structure, testing commands, version control, HIR concepts, aliasing effects, and debugging tips. The settings file grants permissions for yarn snap commands and the feature flag script, while .gitignore is updated to allow local settings overrides.

  • Renamed .claude/settings.local.json to .claude/settings.json and added yarn snap:* and yarn snap:build permissions
  • Added .claude/settings.local.json to gitignore to support local configuration overrides
  • Created comprehensive CLAUDE.md documentation with React Compiler architecture and workflow guidance
  • Minor typo: "explicitlyu" should be "explicitly" on line 38

Confidence Score: 4/5

  • This PR is safe to merge with one minor spelling error to fix
  • The PR only adds documentation and configuration files without changing any runtime code. The settings file correctly references existing scripts (enable-feature-flag.js, yarn snap commands), and the gitignore change follows the pattern of excluding local settings. The only issue is a minor typo.
  • compiler/CLAUDE.md needs a typo fix on line 38

Important Files Changed

Filename Overview
compiler/.claude/settings.json Renamed from settings.local.json and added yarn snap command permissions
compiler/.gitignore Added .claude/settings.local.json to gitignore to support local overrides
compiler/CLAUDE.md Comprehensive documentation for using Claude with React Compiler, contains one typo

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment thread compiler/CLAUDE.md

## Version Control

This repository uses Sapling (`sl`) for version control. Sapling is similar to Mercurial: there is not staging area, but new/deleted files must be explicitlyu added/removed.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: 'explicitlyu' is misspelled

Suggested change
This repository uses Sapling (`sl`) for version control. Sapling is similar to Mercurial: there is not staging area, but new/deleted files must be explicitlyu added/removed.
This repository uses Sapling (`sl`) for version control. Sapling is similar to Mercurial: there is not staging area, but new/deleted files must be explicitly added/removed.
Prompt To Fix With AI
This is a comment left during a code review.
Path: compiler/CLAUDE.md
Line: 38:38

Comment:
**syntax:** 'explicitlyu' is misspelled

```suggestion
This repository uses Sapling (`sl`) for version control. Sapling is similar to Mercurial: there is not staging area, but new/deleted files must be explicitly added/removed.
```

How can I resolve this? If you propose a fix, please make it concise.

@everettbu

Copy link
Copy Markdown
Author

Upstream PR was closed or merged. Code is synced via branch mirror.

@everettbu everettbu closed this Jan 23, 2026
@everettbu
everettbu deleted the pr35523 branch January 23, 2026 19:24
@everettbu
everettbu restored the pr35523 branch January 23, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants