[DevTools] Stop setting unused global variables#359
Closed
everettbu wants to merge 2 commits into
Closed
Conversation
everettbu
force-pushed
the
sebbie/01-16-_devtools_stop_setting_unused_global_variables
branch
from
January 16, 2026 12:14
c8122cc to
3d6180c
Compare
everettbu
marked this pull request as ready for review
January 16, 2026 13:24
Greptile SummaryThis PR removes unused global variables from React DevTools that are no longer read by the DevTools system. The PR eliminates 5 global variables that had no meaningful values and were not being used:
The PR keeps
This is a straightforward cleanup that reduces technical debt and improves code maintainability by removing dead code. Confidence Score: 5/5
Important Files Changed
|
Author
|
Upstream PR was closed or merged. Code is synced via branch mirror. |
everettbu
deleted the
sebbie/01-16-_devtools_stop_setting_unused_global_variables
branch
January 16, 2026 16:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of facebook/react#35532
Original author: eps1lon
We no longer set the following globals since they're not read by DevTools. It also doesn't look like they had any meaningful values anymore which was hidden by missing Flow coverage.
__REACT_DEVTOOLS_APPEND_COMPONENT_STACK____REACT_DEVTOOLS_BREAK_ON_CONSOLE_ERRORS____REACT_DEVTOOLS_SHOW_INLINE_WARNINGS_AND_ERRORS____REACT_DEVTOOLS_HIDE_CONSOLE_LOGS_IN_STRICT_MODE____REACT_DEVTOOLS_DISABLE_SECOND_CONSOLE_LOG_DIMMING_IN_STRICT_MODE____REACT_DEVTOOLS_COMPONENT_FILTERS__is still set since it's still in use (although not fully functional in the browser extension which I intend to fix).