chore: code quality improvements and cleanup#381
Closed
everettbu wants to merge 2 commits into
Closed
Conversation
- Remove obsolete error code 355 for useOpaqueIdentifier This error was for a feature that was never released, as noted in the TODO comment within the error message itself. - Improve @deprecated documentation for noEmit compiler option Clarify the migration path to outputMode and update terminology from 'Forget' to 'the compiler'. - Remove stale TODO comment from ReactNative.js shim The comment suggested deleting the legacy renderer, but this shim is still needed for backward compatibility.
Greptile SummaryThis PR performs code quality cleanup across three areas:
All changes are documentation and dead code removal that don't affect runtime behavior. Confidence Score: 5/5
Important Files Changed
|
Author
|
Upstream PR was closed or merged. Code is synced via branch mirror. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of facebook/react#35563
Original author: Programlog
Summary
This PR contains small code quality improvements and cleanup across the React codebase.
Changes
Remove obsolete error code 355 for
useOpaqueIdentifierImprove
@deprecateddocumentation fornoEmitcompiler optionoutputModeinsteadRemove stale TODO comment from ReactNative.js shim
Test Plan
These are documentation and dead code removal changes that don't affect runtime behavior:
noEmitoption behavior is unchanged, only JSDoc improved