Skip to content

[DevTools] Update inspected element on component filter changes #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
everettbu wants to merge 1 commit into from
Closed

[DevTools] Update inspected element on component filter changes #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/react-devtools-shared/src/backend/agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,6 +1086,15 @@ export default class Agent extends EventEmitter<{
}
renderer.updateComponentFilters(componentFilters);
}

// Due to the component filters changing, we might be able
// to select a closer match for the currently selected host element.
// The store will already select a suitable parent if the the current

@greptile-apps greptile-apps Bot Jan 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: typo: "the the" should be "the"

Suggested change
// The store will already select a suitable parent if the the current
// The store will already select a suitable parent if the current
Prompt To Fix With AI 
This is a comment left during a code review.
Path: packages/react-devtools-shared/src/backend/agent.js
Line: 1092:1092

Comment:
**syntax:** typo: "the the" should be "the"

```suggestion
      // The store will already select a suitable parent if the current
```

How can I resolve this? If you propose a fix, please make it concise.

// selection is now filtered out in which cases this will be a no-op.
const target = window.__REACT_DEVTOOLS_GLOBAL_HOOK__.$0;
if (target != null) {
this.selectNode(target);
}
};

getEnvironmentNames: () => void = () => {
Expand Down
Loading