[DevTools] Fix broken commit tree builder for initial operations#478
Closed
everettbu wants to merge 3 commits into
Closed
[DevTools] Fix broken commit tree builder for initial operations#478everettbu wants to merge 3 commits into
everettbu wants to merge 3 commits into
Conversation
everettbu
marked this pull request as ready for review
February 6, 2026 11:27
Greptile OverviewGreptile SummaryFixes regression introduced in PR #35093 where removing the root ID from operations broke the commit tree builder during profiling. The commit tree builder requires the root ID to properly reconstruct the component tree for each commit. This PR adds back the root parameter to Confidence Score: 5/5
Important Files Changed
|
Author
|
Upstream PR was closed or merged. Code is synced via branch mirror. |
everettbu
deleted the
sebbie/02-06-_devtools_stop_sending_current_root_id_in_operations
branch
February 6, 2026 14:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of facebook/react#35710
Original author: eps1lon
Summary
Originally thought we can stop sending the root ID entirely but it's used by the commit tree builder. That made me realize react/react#35093 introduced a regression.
Flushing pending events is only safe without a root if we're not profiling or if we're flushing events that don't mutate the tree (e.g. console errors and warnings)
Also removes handling of
TREE_OPERATION_REMOVE_ROOTin various frontends since that operation is no longer sent by the backend.How did you test this change?