Skip to content

[test] Move profilingCommitTreeBuilder to versioned renderer#480

Closed
everettbu wants to merge 1 commit into
mainfrom
sebbie/02-06-_test_move_profilingcommittreebuilder_to_versioned_renderer
Closed

[test] Move profilingCommitTreeBuilder to versioned renderer#480
everettbu wants to merge 1 commit into
mainfrom
sebbie/02-06-_test_move_profilingcommittreebuilder_to_versioned_renderer

Conversation

@everettbu

Copy link
Copy Markdown

Mirror of facebook/react#35711
Original author: eps1lon


Summary

Avoids duplicating the tests. Assertions are and should be equivalent anyway.

Test plan

  • modern render test: CI
  • legacy render test: node ./scripts/ci/download_devtools_regression_build.js 16.9 --replaceBuild && node ./scripts/jest/jest-cli.js --build --project devtools --release-channel=experimental --reactVersion 16.9

@everettbu everettbu added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 6, 2026
@greptile-apps

greptile-apps Bot commented Feb 6, 2026

Copy link
Copy Markdown

Greptile Overview

Greptile Summary

  • Refactors profilingCommitBuilder-test.js to use getVersionedRenderImplementation() instead of separate legacy vs createRoot render implementations.
  • Removes duplicated test cases by relying on the version-gated renderer selection in __tests__/utils.js.
  • Keeps the same profiling workflow (start/stop profiling, render multiple commits) and validates commit tree reconstruction via snapshots and commitTree node counts.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • Change is confined to a single test file and uses an existing version-gated renderer helper already used across the test suite; assertions remain equivalent and no production code paths are modified.
  • No files require special attention

Important Files Changed

Filename Overview
packages/react-devtools-shared/src/tests/profilingCommitTreeBuilder-test.js Consolidates legacy and createRoot profiling commit tree builder tests into a single test using getVersionedRenderImplementation(), avoiding duplicated assertions while preserving snapshots and commitTree size checks.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@everettbu

Copy link
Copy Markdown
Author

Upstream PR was closed or merged. Code is synced via branch mirror.

@everettbu everettbu closed this Feb 6, 2026
@everettbu
everettbu deleted the sebbie/02-06-_test_move_profilingcommittreebuilder_to_versioned_renderer branch February 6, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants