Skip to content

[test] Include uniqueSuspenders in Suspense tree snapshots#494

Closed
everettbu wants to merge 1 commit into
mainfrom
sebbie/02-09-_test_include_uniquesuspenders_in_suspense_tree_snapshots
Closed

[test] Include uniqueSuspenders in Suspense tree snapshots#494
everettbu wants to merge 1 commit into
mainfrom
sebbie/02-09-_test_include_uniquesuspenders_in_suspense_tree_snapshots

Conversation

@everettbu

Copy link
Copy Markdown

Mirror of facebook/react#35736
Original author: eps1lon


This field is important to show only boundaries that can have their fallback shown so we should include it in tests.

This change doesn't imply the values in the existing tests are correct.

@everettbu everettbu added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 9, 2026
@everettbu
everettbu marked this pull request as ready for review February 10, 2026 00:46
@greptile-apps

greptile-apps Bot commented Feb 10, 2026

Copy link
Copy Markdown

Greptile Overview

Greptile Summary

This PR updates DevTools test snapshots so printed Suspense tree nodes include a uniqueSuspenders={...} attribute (derived from SuspenseNode.hasUniqueSuspenders). The only production change is in packages/react-devtools-shared/src/devtools/utils.js, where printStore’s Suspense snapshot output now prints this field; the rest of the changes are inline snapshot updates across Store/TreeContext/Profiler commit-tree tests.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • Changes are limited to snapshot formatting in test utilities plus corresponding inline snapshot updates; no behavioral changes to DevTools runtime logic beyond test output formatting.
  • No files require special attention

Important Files Changed

Filename Overview
packages/react-devtools-shared/src/devtools/utils.js Updates Suspense snapshot printer to include uniqueSuspenders based on SuspenseNode.hasUniqueSuspenders.
packages/react-devtools-shared/src/tests/profilingCommitTreeBuilder-test.js Adjusts inline snapshots to include uniqueSuspenders={...} on printed Suspense nodes.
packages/react-devtools-shared/src/tests/store-test.js Updates Store-related inline snapshots for Suspense tree printing to include uniqueSuspenders={...}.
packages/react-devtools-shared/src/tests/storeComponentFilters-test.js Updates component filter tests’ Suspense tree snapshots to include uniqueSuspenders={...} values.
packages/react-devtools-shared/src/tests/treeContext-test.js Updates TreeContext-related inline snapshots to print Suspense nodes with uniqueSuspenders={...}.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@everettbu

Copy link
Copy Markdown
Author

Upstream PR was closed or merged. Code is synced via branch mirror.

@everettbu everettbu closed this Feb 10, 2026
@everettbu
everettbu deleted the sebbie/02-09-_test_include_uniquesuspenders_in_suspense_tree_snapshots branch February 10, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants