[DevTools] Only block child Suspense boundaries if the parent has all shared suspenders removed#495
Closed
everettbu wants to merge 2 commits into
Conversation
Greptile OverviewGreptile SummaryThis PR tightens the DevTools Suspense “unblocking” logic so child Suspense boundaries are only reconsidered for unblocking after the parent has actually removed the last remaining dependency for a given I/O entry. Previously, unblocking could be triggered even when some children were still suspended on that same I/O, which could incorrectly mark child boundaries as having unique suspenders. A new store test exercises a stacked outer/inner Suspense scenario to lock in the corrected behavior and prevent regressions. Confidence Score: 5/5
Important Files Changed
|
… shared suspenders removed
everettbu
force-pushed
the
sebbie/02-09-_devtools_only_block_child_suspense_boundaries_if_the_parent_has_all_shared_suspenders_removed
branch
from
February 10, 2026 15:40
eaa0db2 to
4cd0fb6
Compare
Author
|
Upstream PR was closed or merged. Code is synced via branch mirror. |
everettbu
deleted the
sebbie/02-09-_devtools_only_block_child_suspense_boundaries_if_the_parent_has_all_shared_suspenders_removed
branch
February 10, 2026 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of facebook/react#35737
Original author: eps1lon
Summary
Stacked on react/react#35736
A Suspense boundary is considered unblocked by I/O removal if no more children (until the next Suspense boundary) are blocked on the same I/O. However, we used to unblock if at least one children with this I/O was removed. Now we check if no more children are blocked on the same I/O.
This was probably an oversight. The unblocking should happen in the same codeblock that checks if all dependencies are removed.
Found with Claude + Opus 4.6
How did you test this change?