[DevTools] Check suspense child node presence in parentSuspense.children before removing

[everettbu]

Mirror of facebook/react#35775
Original author: hoxyq

---

Currently, this silently removes the last child in the list, which doesn't contain the id.

[greptile-apps]

Greptile Overview

Greptile Summary

Adds a defensive check before removing a suspense child node from its parent's children array in the DevTools store. Previously, if indexOf(id) returned -1 (node not found), splice(-1, 1) would silently remove the last element in the array — a subtle bug that could corrupt the suspense tree state. The fix calls _throwAndEmitError when the child is not found, which is consistent with other guard patterns in the same file.

• Prevents silent removal of the wrong child node when a suspense node ID is not found in its parent's children array
• The analogous non-suspense node removal path (line 1619-1620) has the same unguarded pattern and could benefit from a similar fix

Confidence Score: 4/5

• This PR is safe to merge — it adds a straightforward defensive check that prevents data corruption in an error case.
• The change is minimal, targeted, and follows established patterns in the codebase. The _throwAndEmitError method always throws (return type empty), so the subsequent splice is correctly unreachable when the guard triggers. No functional behavior changes for the happy path.
• No files require special attention. The single changed file has a clean, well-scoped modification.

Important Files Changed

Filename	Overview
packages/react-devtools-shared/src/devtools/store.js	Adds a bounds check before splice to prevent silently removing the last child when a suspense node ID is not found in the parent's children array. The fix is correct and follows existing error handling patterns.

_{Last reviewed commit: cce34d3}

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Analogous check missing for non-suspense nodes

This guard is a good fix. Note that the same unguarded indexOf + splice pattern exists for the non-suspense element removal path at line 1619-1620:

const index = parentElement.children.indexOf(id);
parentElement.children.splice(index, 1);

That path has the same silent-last-child-removal bug. It might be worth adding a similar check there for consistency. Not blocking this PR, but flagging for awareness.

Prompt To Fix With AI

This is a comment left during a code review.
Path: packages/react-devtools-shared/src/devtools/store.js
Line: 1876:1882

Comment:
**Analogous check missing for non-suspense nodes**

This guard is a good fix. Note that the same unguarded `indexOf` + `splice` pattern exists for the non-suspense element removal path at line 1619-1620:

```js
const index = parentElement.children.indexOf(id);
parentElement.children.splice(index, 1);
```

That path has the same silent-last-child-removal bug. It might be worth adding a similar check there for consistency. Not blocking this PR, but flagging for awareness.

How can I resolve this? If you propose a fix, please make it concise.

[everettbu]

Upstream PR was closed or merged. Code is synced via branch mirror.