Skip to content

fix: set private field to boolean in devtools fusebox package#525

Open
everettbu wants to merge 1 commit into
mainfrom
codex/issue-35793-private-boolean
Open

fix: set private field to boolean in devtools fusebox package#525
everettbu wants to merge 1 commit into
mainfrom
codex/issue-35793-private-boolean

Conversation

@everettbu

Copy link
Copy Markdown

Mirror of facebook/react#35796
Original author: Arktomson


Summary

This change updates packages/react-devtools-fusebox/package.json to use a boolean for the private field instead of a string.

  • Changed "private": "true" to "private": true.
  • This aligns the package metadata with standard package.json schema expectations.
  • Scope is intentionally minimal and does not change runtime behavior.

How did you test this change?

I validated the package metadata value and type after the change.

node -e "const p=require('./packages/react-devtools-fusebox/package.json'); if (typeof p.private !== 'boolean') { throw new Error('private is not boolean'); } console.log('private is boolean:', p.private);"

Output:

private is boolean: true

Additionally, this is a metadata-only change in package.json, so no runtime code path is affected.


@greptile-apps

greptile-apps Bot commented Feb 16, 2026

Copy link
Copy Markdown

Greptile Summary

Fixes the private field in packages/react-devtools-fusebox/package.json from the string "true" to the boolean true, aligning it with the package.json spec and the convention used by all other react-devtools-* packages.

  • The private field in package.json is expected to be a boolean. While npm treats the string "true" as truthy and still prevents publishing, the boolean is the correct type per the schema.
  • All other devtools packages (react-devtools-timeline, react-devtools-shell, react-devtools-extensions, react-devtools-shared) already use the boolean form.
  • Note: two packages under compiler/packages/react-forgive/ still have the same string "true" issue, but those are outside the scope of this PR.

Confidence Score: 5/5

  • This PR is safe to merge — it is a minimal, metadata-only fix with no runtime impact.
  • Single-character change in a package.json metadata field, correcting a type from string to boolean. No runtime code is affected, and the change aligns with the npm spec and existing conventions in the repo.
  • No files require special attention.

Important Files Changed

Filename Overview
packages/react-devtools-fusebox/package.json Corrects "private" field from string "true" to boolean true, aligning with the package.json spec and other devtools packages.

Last reviewed commit: 49647ae

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants