Conversation
This feels a *bit* like a hack since I'm just converting the number into a string, but that's just reflecting what happens at runtime. The downside here is that if we converted these identifiers anywhere outside of object keys back to code, we would need to watch out for that. For example, we might convert an object destructure into a property access which would need to use `obj[2]` instead of obj.bar, but I that should also be the case of property access with string keys that are not valid identifiers
Greptile OverviewGreptile SummaryAdded support for numeric object keys in the React compiler by converting
Confidence Score: 5/5
Important Files ChangedFile Analysis
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of facebook/react#30680
Original author: kassens
This feels a bit like a hack since I'm just converting the number into a string, but that's just reflecting what happens at runtime. The downside here is that if we converted these identifiers anywhere outside of object keys back to code, we would need to watch out for that.
For example, we might convert an object destructure into a property access which would need to use
obj[2]instead of obj.bar, but I that should also be the case of property access with string keys that are not valid identifiers