[compiler] Surface all lint diagnostics instead of stopping at first validation error

compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Pipeline.ts

@@ -196,10 +196,18 @@ function runWithEnvironment(
 
   if (env.enableValidations) {
     if (env.config.validateHooksUsage) {
-      validateHooksUsage(hir).unwrap();
+      if (env.outputMode === 'lint') {
+        env.logErrors(validateHooksUsage(hir));
+      } else {
+        validateHooksUsage(hir).unwrap();
+      }
     }
     if (env.config.validateNoCapitalizedCalls) {
-      validateNoCapitalizedCalls(hir).unwrap();
+      if (env.outputMode === 'lint') {
+        env.logErrors(validateNoCapitalizedCalls(hir));
+      } else {
+        validateNoCapitalizedCalls(hir).unwrap();
+      }
     }
   }
 

compiler/packages/babel-plugin-react-compiler/src/HIR/Environment.ts

@@ -696,7 +696,7 @@ export class Environment {
     return this.#scope;
   }
 
-  logErrors(errors: Result<void, CompilerError>): void {
+  logErrors(errors: Result<unknown, CompilerError>): void {
     if (errors.isOk() || this.logger == null) {
       return;
     }

compiler/packages/eslint-plugin-react-compiler/__tests__/PluginTest-test.ts

@@ -57,7 +57,6 @@ testRule('plugin-recommended', TestRecommendedRules, {
   ],
   invalid: [
     {
-      // TODO: actually return multiple diagnostics in this case
       name: 'Multiple diagnostic kinds from the same function are surfaced',
       code: normalizeIndent`
         import Child from './Child';
@@ -70,6 +69,7 @@ testRule('plugin-recommended', TestRecommendedRules, {
       `,
       errors: [
         makeTestCaseError('Hooks must always be called in a consistent order'),
+        makeTestCaseError('Capitalized functions are reserved for components'),
       ],
     },
     {

compiler/packages/eslint-plugin-react-compiler/__tests__/Repro35394-test.ts

@@ -0,0 +1,63 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+import {normalizeIndent, TestRecommendedRules, testRule} from './shared-utils';
+
+testRule('repro-35394', TestRecommendedRules, {
+  valid: [],
+  invalid: [
+    {
+      name: '#35394 repro - multiple violations with useState in nested component',
+      code: normalizeIndent`
+        import {useState, useEffect} from 'react';
+        export default function App() {
+          const [foo, setFoo] = useState(false);
+
+          useEffect(() => {
+            setFoo(!foo);
+          }, []);
+
+          const ViolateStaticComponents = () => {
+            const [counter, setCounter] = useState(0);
+            return <h1>Hello, World!</h1>;
+          };
+
+          return (
+            <>
+              <ViolateStaticComponents />
+            </>
+          );
+        }
+      `,
+      errors: 3,
+    },
+    {
+      name: 'Without nested useState - should show 2 errors',
+      code: normalizeIndent`
+        import {useState, useEffect} from 'react';
+        export default function App() {
+          const [foo, setFoo] = useState(false);
+
+          useEffect(() => {
+            setFoo(!foo);
+          }, []);
+
+          const ViolateStaticComponents = () => {
+            return <h1>Hello, World!</h1>;
+          };
+
+          return (
+            <>
+              <ViolateStaticComponents />
+            </>
+          );
+        }
+      `,
+      errors: 2,
+    },
+  ],
+});