Skip to content

fix: change private field from string to boolean#582

Open
everettbu wants to merge 1 commit into
mainfrom
fix/private-field-bool
Open

fix: change private field from string to boolean#582
everettbu wants to merge 1 commit into
mainfrom
fix/private-field-bool

Conversation

@everettbu

Copy link
Copy Markdown

Mirror of facebook/react#35863
Original author: pickmemory


Summary

This PR fixes the malformed private field in packages/react-devtools-fusebox/package.json.

Bug

The private field was set to string "true" instead of boolean true, which causes failures in package scanning tools that validate package metadata.

Fix

Changed "private": "true" to "private": true

Related

  • Reported in issue #35793
  • npm package.json specification requires boolean for private field

According to npm specification, private field must be boolean not string.
@greptile-apps

greptile-apps Bot commented Feb 22, 2026

Copy link
Copy Markdown

Greptile Summary

Fixes the private field in packages/react-devtools-fusebox/package.json from the string "true" to the boolean true, aligning it with the npm specification and the convention used by all other package.json files in the repository.

  • Changed "private": "true" to "private": true in packages/react-devtools-fusebox/package.json
  • Note: two similar instances of "private": "true" still exist in compiler/packages/react-forgive/server/package.json and compiler/packages/react-forgive/client/package.json, which could be addressed in a follow-up

Confidence Score: 5/5

  • This PR is safe to merge — it is a minimal, correct one-character fix to a JSON metadata field.
  • The change is a single-character type correction (string to boolean) in a package.json file. It aligns with npm's specification, matches the convention used by all other private packages in this repository, and carries zero risk of runtime breakage.
  • No files require special attention.

Important Files Changed

Filename Overview
packages/react-devtools-fusebox/package.json Corrects private field from string "true" to boolean true, matching npm's package.json specification and the convention used across the rest of the repository.

Last reviewed commit: 94b1253

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants