Bump minimatch from 3.0.4 to 10.2.1#586
Conversation
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 10.2.1. - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.0.4...v10.2.1) --- updated-dependencies: - dependency-name: minimatch dependency-version: 10.2.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Greptile SummaryDependabot security update bumping
Confidence Score: 3/5
Important Files Changed
Last reviewed commit: 344c994 |
| "jest-silent-reporter": "^0.6.0", | ||
| "jest-snapshot-serializer-raw": "^1.2.0", | ||
| "minimatch": "^3.0.4", | ||
| "minimatch": "^10.2.1", |
There was a problem hiding this comment.
Major version jump: verify CommonJS compatibility
This bumps minimatch across 7 major versions (3 → 10). Key breaking changes include:
- v9.0: No default export, only named exports
- v10.0: Requires Node 20 or 22+
The only direct usage is in scripts/eslint/index.js:
const minimatch = require('minimatch');
// ...
minimatch.match(files, pattern, {matchBase: true});Since match is a named export in v10, require('minimatch').match should still resolve correctly via CommonJS. The Node 20+ requirement is also satisfied (.nvmrc specifies v20.19.0). However, given the magnitude of this version jump, it would be prudent to verify the ESLint script still works as expected (e.g., by running node -e "const m = require('minimatch'); console.log(typeof m.match)" after install).
Additionally, Dependabot flags that this version adds a prepare install script — worth reviewing the package contents before merging.
Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 93
Comment:
**Major version jump: verify CommonJS compatibility**
This bumps minimatch across 7 major versions (3 → 10). Key breaking changes include:
- **v9.0**: No default export, only named exports
- **v10.0**: Requires Node 20 or 22+
The only direct usage is in `scripts/eslint/index.js`:
```js
const minimatch = require('minimatch');
// ...
minimatch.match(files, pattern, {matchBase: true});
```
Since `match` is a named export in v10, `require('minimatch').match` should still resolve correctly via CommonJS. The Node 20+ requirement is also satisfied (`.nvmrc` specifies `v20.19.0`). However, given the magnitude of this version jump, it would be prudent to verify the ESLint script still works as expected (e.g., by running `node -e "const m = require('minimatch'); console.log(typeof m.match)"` after install).
Additionally, Dependabot flags that this version adds a `prepare` install script — worth reviewing the package contents before merging.
How can I resolve this? If you propose a fix, please make it concise.|
Upstream PR was closed or merged. Code is synced via branch mirror. |
Mirror of facebook/react#35866
Original author: app/dependabot
Bumps minimatch from 3.0.4 to 10.2.1.
Changelog
Sourced from minimatch's changelog.
... (truncated)
Commits
6d7ac3410.2.12e111f3coalesce consecutive non-globstar * characters1a62a2a10.2.0758b5a3changelog 10.2903e50badd braceExpandMax option, formata50a11010.1.3a08c046move back to og brace-expansionfde70d110.1.205210d8update depsba4093cupdate workflows and package stuffInstall script changes
This version adds
preparescript that runs during installation. Review the package contents before updating.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot
rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
rebasewill rebase this PRrecreatewill recreate this PR, overwriting any edits that have been made to itshow <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependencyignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.