Skip to content

Bump minimatch from 3.0.4 to 10.2.1#586

Closed
everettbu wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/minimatch-10.2.1
Closed

Bump minimatch from 3.0.4 to 10.2.1#586
everettbu wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/minimatch-10.2.1

Conversation

@everettbu

Copy link
Copy Markdown

Mirror of facebook/react#35866
Original author: app/dependabot


Bumps minimatch from 3.0.4 to 10.2.1.

Changelog

Sourced from minimatch's changelog.

change log

10.2

  • Add braceExpandMax option

10.1

  • Add magicalBraces option for escape
  • Fix makeRe when partial: true is set.
  • Fix makeRe when pattern ends in a final ** path part.

10.0

  • Require node 20 or 22 and higher

9.0

  • No default export, only named exports.

8.0

  • Recursive descent parser for extglob, allowing correct support for arbitrarily nested extglob expressions
  • Bump required Node.js version

7.4

  • Add escape() method
  • Add unescape() method
  • Add Minimatch.hasMagic() method

7.3

  • Add support for posix character classes in a unicode-aware way.

7.2

  • Add windowsNoMagicRoot option

7.1

  • Add optimizationLevel configuration option, and revert the default back to the 6.2 style minimal optimizations, making the advanced transforms introduced in 7.0 opt-in. Also, process provided file paths in the same way in optimizationLevel:2 mode, so most things that matched with optimizationLevel 1 or 0 should match with level 2 as well. However, level 1 is the default, out of an abundance of caution.

... (truncated)

Commits
Install script changes

This version adds prepare script that runs during installation. Review the package contents before updating.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • ``@dependabot rebase will rebase this PR
  • ``@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • ``@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • ``@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • ``@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • ``@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 10.2.1.
- [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
- [Commits](isaacs/minimatch@v3.0.4...v10.2.1)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-version: 10.2.1
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@everettbu everettbu added CLA Signed dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Feb 22, 2026
@greptile-apps

greptile-apps Bot commented Feb 22, 2026

Copy link
Copy Markdown

Greptile Summary

Dependabot security update bumping minimatch from 3.0.4 to 10.2.1 (7 major versions). This is a devDependency used only in scripts/eslint/index.js for file pattern matching. The yarn.lock correctly adds minimatch 10.2.1 with its new dependency chain (brace-expansion ^5.0.2, balanced-match ^4.0.2) while preserving existing 3.x resolutions for transitive dependencies.

  • The Node 20+ requirement (introduced in v10.0) is satisfied by the project's .nvmrc (v20.19.0)
  • The only direct usage (minimatch.match()) should remain compatible since match is available as a named export in v10.x
  • Dependabot notes this version adds a prepare install script — the package contents should be reviewed before merging
  • The yarn.lock also consolidates two separate minimatch@^9.x entries into one (resolving both to 9.0.5), which is a healthy dedup

Confidence Score: 3/5

  • Likely safe but involves a large major version jump on a devDependency — manual verification of the ESLint script is recommended before merging.
  • Score of 3 reflects that while the API usage pattern should remain compatible, this is a 7 major version bump with multiple breaking changes (export style, Node version requirements, dependency chain overhaul). The usage is limited to a single devDependency script, lowering risk, but the lack of any code changes to adapt to the new API suggests this was auto-generated without testing the affected script.
  • Pay attention to package.json for the major version bump and verify that scripts/eslint/index.js still works correctly with minimatch 10.x.

Important Files Changed

Filename Overview
package.json Bumps minimatch from ^3.0.4 to ^10.2.1 — a 7 major version jump. The API usage in scripts/eslint/index.js (CommonJS require + .match()) should still work with named exports, but this is a significant version leap that warrants verification.
yarn.lock Adds minimatch 10.2.1 with new dependency chain (brace-expansion ^5.0.2, balanced-match ^4.0.2). Also consolidates existing minimatch 3.x and 9.x entries, deduplicating the 9.0.1 entry into 9.0.5. Changes look correct and consistent.

Last reviewed commit: 344c994

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment thread package.json
"jest-silent-reporter": "^0.6.0",
"jest-snapshot-serializer-raw": "^1.2.0",
"minimatch": "^3.0.4",
"minimatch": "^10.2.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version jump: verify CommonJS compatibility

This bumps minimatch across 7 major versions (3 → 10). Key breaking changes include:

  • v9.0: No default export, only named exports
  • v10.0: Requires Node 20 or 22+

The only direct usage is in scripts/eslint/index.js:

const minimatch = require('minimatch');
// ...
minimatch.match(files, pattern, {matchBase: true});

Since match is a named export in v10, require('minimatch').match should still resolve correctly via CommonJS. The Node 20+ requirement is also satisfied (.nvmrc specifies v20.19.0). However, given the magnitude of this version jump, it would be prudent to verify the ESLint script still works as expected (e.g., by running node -e "const m = require('minimatch'); console.log(typeof m.match)" after install).

Additionally, Dependabot flags that this version adds a prepare install script — worth reviewing the package contents before merging.

Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 93

Comment:
**Major version jump: verify CommonJS compatibility**

This bumps minimatch across 7 major versions (3 → 10). Key breaking changes include:

- **v9.0**: No default export, only named exports
- **v10.0**: Requires Node 20 or 22+

The only direct usage is in `scripts/eslint/index.js`:
```js
const minimatch = require('minimatch');
// ...
minimatch.match(files, pattern, {matchBase: true});
```

Since `match` is a named export in v10, `require('minimatch').match` should still resolve correctly via CommonJS. The Node 20+ requirement is also satisfied (`.nvmrc` specifies `v20.19.0`). However, given the magnitude of this version jump, it would be prudent to verify the ESLint script still works as expected (e.g., by running `node -e "const m = require('minimatch'); console.log(typeof m.match)"` after install).

Additionally, Dependabot flags that this version adds a `prepare` install script — worth reviewing the package contents before merging.

How can I resolve this? If you propose a fix, please make it concise.

@everettbu

Copy link
Copy Markdown
Author

Upstream PR was closed or merged. Code is synced via branch mirror.

@everettbu everettbu closed this Feb 25, 2026
@everettbu
everettbu deleted the dependabot/npm_and_yarn/minimatch-10.2.1 branch February 25, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant