fix: correct private field type in react-devtools-fusebox package.json#615
Open
everettbu wants to merge 2 commits into
Open
fix: correct private field type in react-devtools-fusebox package.json#615everettbu wants to merge 2 commits into
everettbu wants to merge 2 commits into
Conversation
The integer 10 readonly '!'=0
integer 10 readonly '#'=0
integer 10 readonly '$'=31653
array readonly '*'=( )
readonly -=569Xils
0=/bin/zsh
integer 10 readonly '?'=0
array readonly @=( )
ANTIGRAVITY_AGENT=1
ANTIGRAVITY_CLI_ALIAS=agy
integer 10 readonly ARGC=0
tied cdpath CDPATH=''
COLORTERM=truecolor
integer 10 COLUMNS=24
COMMAND_MODE=unix2003
CPUTYPE=arm64
integer 10 EGID=20
integer 10 EUID=501
tied fignore FIGNORE=''
tied fpath FPATH=/opt/homebrew/share/zsh/site-functions:/usr/local/share/zsh/site-functions:/usr/share/zsh/site-functions:/usr/share/zsh/5.9/functions
integer 10 FUNCNEST=700
integer 10 GID=20
GIT_ASKPASS=/Applications/Antigravity.app/Contents/Resources/app/extensions/git/dist/askpass.sh
HISTCHARS='!^#'
integer 10 readonly HISTCMD=1516
HISTFILE=/Users/sudipkumarprasad/.zsh_history
integer 10 HISTSIZE=2000
HOME=/Users/sudipkumarprasad
HOMEBREW_CELLAR=/opt/homebrew/Cellar
HOMEBREW_PREFIX=/opt/homebrew
HOMEBREW_REPOSITORY=/opt/homebrew
HOST=sudips-MacBook-Pro.local
IFS=$' \t\n\C-@'
INFOPATH=/opt/homebrew/share/info:/opt/homebrew/share/info:
KEYBOARD_HACK=''
integer KEYTIMEOUT=40
LANG=C.UTF-8
integer 10 readonly LINENO=8
integer 10 LINES=12
integer LISTMAX=100
LOGNAME=sudipkumarprasad
MACHTYPE=x86_64
integer MAILCHECK=60
tied mailpath MAILPATH=''
tied manpath MANPATH=''
tied module_path MODULE_PATH=/usr/lib/zsh/5.9
MallocNanoZone=0
NULLCMD=cat
NVM_BIN=/Users/sudipkumarprasad/.nvm/versions/node/v24.6.0/bin
NVM_CD_FLAGS=-q
NVM_DIR=/Users/sudipkumarprasad/.nvm
NVM_INC=/Users/sudipkumarprasad/.nvm/versions/node/v24.6.0/include/node
OLDPWD=/Users/sudipkumarprasad/Desktop/react
OPTARG=''
integer 10 OPTIND=1
OSLogRateLimit=64
OSTYPE=darwin25.0
PAGER=cat
tied path PATH=/Users/sudipkumarprasad/.antigravity/antigravity/bin:/usr/local/mysql/bin:/Users/sudipkumarprasad/.nvm/versions/node/v24.6.0/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/Library/Frameworks/Python.framework/Versions/3.12/bin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Library/Apple/usr/bin:/Users/sudipkumarprasad/.antigravity/antigravity/bin:/usr/local/mysql/bin:/Users/sudipkumarprasad/.nvm/versions/node/v24.6.0/bin
POWERLEVEL9K_INSTANT_PROMPT=off
integer 10 readonly PPID=9214
PROMPT='%n@%m %1~ %# '
PROMPT2='%_> '
PROMPT3='?# '
PROMPT4='+%N:%i> '
PS1='%n@%m %1~ %# '
PS2='%_> '
PS3='?# '
PS4='+%N:%i> '
tied psvar PSVAR=''
PWD=/Users/sudipkumarprasad/Desktop/react
integer 10 RANDOM=17654
READNULLCMD=more
integer 10 SAVEHIST=1000
integer 10 SECONDS=572
SHELL=/bin/zsh
integer 10 SHLVL=1
SPROMPT='zsh: correct '\''%R'\'' to '\''%r'\'' [nyae]? '
SSH_AUTH_SOCK=/private/tmp/com.apple.launchd.WSniYVehJc/Listeners
TERM=xterm-256color
TERM_PROGRAM=vscode
TERM_PROGRAM_VERSION=1.107.0
TIMEFMT='%J %U user %S system %P cpu %*E total'
TMPDIR=/var/folders/w3/nkpsnrs11yvf1yk6zkjvd5y00000gn/T/
TMPPREFIX=/tmp/zsh
integer 10 TRY_BLOCK_ERROR=-1
integer 10 TRY_BLOCK_INTERRUPT=-1
TTY=/dev/ttys010
integer 10 readonly TTYIDLE=0
integer 10 UID=501
USER=sudipkumarprasad
USERNAME=sudipkumarprasad
USER_ZDOTDIR=/Users/sudipkumarprasad
VENDOR=apple
VSCODE_GIT_ASKPASS_EXTRA_ARGS=''
VSCODE_GIT_ASKPASS_MAIN=/Applications/Antigravity.app/Contents/Resources/app/extensions/git/dist/askpass-main.js
VSCODE_GIT_ASKPASS_NODE='/Applications/Antigravity.app/Contents/Frameworks/Antigravity Helper (Plugin).app/Contents/MacOS/Antigravity Helper (Plugin)'
VSCODE_GIT_IPC_HANDLE=/var/folders/w3/nkpsnrs11yvf1yk6zkjvd5y00000gn/T/vscode-git-be7968b00b.sock
VSCODE_INJECTION=1
VSCODE_PROFILE_INITIALIZED=1
VSCODE_PYTHON_AUTOACTIVATE_GUARD=1
VSCODE_SHELL_INTEGRATION=1
VSCODE_ZDOTDIR=/private/var/folders/w3/nkpsnrs11yvf1yk6zkjvd5y00000gn/T/sudipkumarprasad-antigravity-zsh
undefined WATCH
WORDCHARS='*?_-.[]~=/&;!#$%^(){}<>'
XPC_FLAGS=0x0
XPC_SERVICE_NAME=application.com.google.antigravity.86439681.86439687
ZDOTDIR=/Users/sudipkumarprasad
ZLE_LINE_ABORTED=''
ZSH_ARGZERO=/bin/zsh
readonly tied zsh_eval_context ZSH_EVAL_CONTEXT=toplevel:cmdsubst
ZSH_NAME=zsh
ZSH_PATCHLEVEL=zsh-5.9-0-g73d3173
integer 10 readonly ZSH_SUBSHELL=1
ZSH_VERSION=5.9
_=private
__CFBundleIdentifier=com.google.antigravity
__CF_USER_TEXT_ENCODING=0x1F5:0x0:0x0
__p9k_sourced=disabled_by_antigravity
__vsc_current_command=$'cd /Users/sudipkumarprasad/Desktop/react && git add packages/react-devtools-fusebox/package.json && git commit -m "fix: correct private field type in react-devtools-fusebox package.json\n\nThe `private` field was incorrectly set to a string value (\\"true\\")\ninstead of the boolean value (true) per the npm specification.\n\nFixes #35793"'
array __vsc_env_keys=( )
array __vsc_env_values=( )
__vsc_in_command_execution=1
__vsc_nonce=c57eb061-076f-469d-849b-55d492cfbaa9
__vsc_prior_prompt='%n@%m %1~ %# '
__vsc_prior_prompt2='%_> '
__vsc_use_aa=1
__vscode_shell_env_reporting=''
array unique _comp_assocs=( '' )
_comp_dumpfile=/Users/sudipkumarprasad/.zcompdump
array _comp_options
_comp_setup
association _compautos
association _comps
association _lastcomp
association _patcomps
association _postpatcomps
association _services
undefined aliases
array argv=( )
undefined builtins
array tied CDPATH cdpath=( )
association commands
array comppostfuncs=( )
array compprefuncs=( )
undefined dirstack
undefined dis_aliases
undefined dis_builtins
undefined dis_functions
undefined dis_functions_source
undefined dis_galiases
undefined dis_patchars
undefined dis_reswords
undefined dis_saliases
array envVarsToReport=( '' )
array tied FIGNORE fignore=( )
array tied FPATH fpath=( /opt/homebrew/share/zsh/site-functions /usr/local/share/zsh/site-functions /usr/share/zsh/site-functions /usr/share/zsh/5.9/functions )
undefined funcfiletrace
undefined funcsourcetrace
array readonly funcstack
undefined functions
undefined functions_source
undefined functrace
undefined galiases
histchars='!^#'
undefined history
undefined historywords
undefined jobdirs
undefined jobstates
undefined jobtexts
key=''
undefined keymaps
array tied MAILPATH mailpath=( )
array tied MANPATH manpath=( '' )
array tied MODULE_PATH module_path=( /usr/lib/zsh/5.9 )
undefined modules
undefined nameddirs
association options
undefined parameters
undefined patchars
array tied PATH path=( /Users/sudipkumarprasad/.antigravity/antigravity/bin /usr/local/mysql/bin /Users/sudipkumarprasad/.nvm/versions/node/v24.6.0/bin /opt/homebrew/bin /opt/homebrew/sbin /Library/Frameworks/Python.framework/Versions/3.12/bin /usr/local/bin /System/Cryptexes/App/usr/bin /usr/bin /bin /usr/sbin /sbin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin /Library/Apple/usr/bin /Users/sudipkumarprasad/.antigravity/antigravity/bin /usr/local/mysql/bin /Users/sudipkumarprasad/.nvm/versions/node/v24.6.0/bin )
array pipestatus=( 0 )
array precmd_functions=( __vsc_precmd )
array preexec_functions=( __vsc_preexec )
prompt='%n@%m %1~ %# '
array tied PSVAR psvar=( )
undefined reswords
undefined saliases
array signals=( EXIT HUP INT QUIT ILL TRAP ABRT EMT FPE KILL BUS SEGV SYS PIPE ALRM TERM URG STOP TSTP CONT CHLD TTIN TTOU IO XCPU XFSZ VTALRM PROF WINCH INFO USR1 USR2 ZERR DEBUG )
integer 10 readonly status=0
undefined termcap
association readonly terminfo
undefined userdirs
undefined usergroups
association vsc_aa_env=( )
undefined watch
undefined widgets
array zle_bracketed_paste=( $'\C-[[?2004h' $'\C-[[?2004l' )
array readonly tied ZSH_EVAL_CONTEXT zsh_eval_context=( toplevel cmdsubst )
undefined zsh_scheduled_events field was incorrectly set to a string value ("true")
instead of the boolean value (true) per the npm specification.
Fixes #35793
Greptile SummaryThis PR fixes a non-compliant
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 2d59cb2 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "@types/vscode": "^1.95.0" | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Missing final newline
All three changed files had their trailing newline stripped. The repository's .editorconfig specifies insert_final_newline = true, and other package.json files in the repo (e.g., packages/react/package.json) end with a newline. Please restore the final newline in this file, as well as in compiler/packages/react-forgive/server/package.json and packages/react-devtools-fusebox/package.json.
Suggested change
| } | |
| } |
Prompt To Fix With AI
This is a comment left during a code review.
Path: compiler/packages/react-forgive/client/package.json
Line: 22
Comment:
**Missing final newline**
All three changed files had their trailing newline stripped. The repository's `.editorconfig` specifies `insert_final_newline = true`, and other `package.json` files in the repo (e.g., `packages/react/package.json`) end with a newline. Please restore the final newline in this file, as well as in `compiler/packages/react-forgive/server/package.json` and `packages/react-devtools-fusebox/package.json`.
```suggestion
}
```
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of facebook/react#35904
Original author: sudip-kumar-prasad
Summary
Fixes #35793
The
privatefield in packages/react-devtools-fusebox/package.json wasincorrectly set to a string
"true"instead of the booleantrue.The npm specification
explicitly states this field must be a boolean. Using a string is malformed
and non-compliant, even if package managers happen to tolerate it.
Changes
"private": "true"→"private": trueTest Plan
No functional behavior changes. This is a correctness fix to conform to the
npm package.json specification.