[noop] Fail tests on unasserted recoverable errors

[everettbu]

Mirror of facebook/react#35948
Original author: eps1lon

---

react-noop-renderer previously swallowed recoverable errors (from onRecoverableError). Now we pass those through to console.error so that we fail the test unless assertConsoleError

[greptile-apps]

Greptile Summary

This PR enables react-noop-renderer to surface recoverable errors (from onRecoverableError) via console.error instead of silently swallowing them. This ensures that tests using the noop renderer will fail if they trigger recoverable errors without explicitly asserting them via assertConsoleErrorDev, improving test reliability and error visibility.

• createReactNoop.js: onRecoverableError now calls console.error(error) with Flow type annotations and appropriate eslint-disable comments
• 3 test files updated: Added assertConsoleErrorDev assertions for the concurrent rendering recovery error message in all tests that trigger error recovery
• useMemoCache-test.js: Replaced manual spyOnDev(console, 'error') spy with proper assertConsoleErrorDev assertion, and consolidated internal-test-utils imports

Confidence Score: 5/5

• This PR is safe to merge — it improves test strictness without changing runtime behavior.
• The changes are minimal, well-scoped, and follow established patterns. The core change (enabling console.error in onRecoverableError) only affects the test renderer, and all affected tests have been updated with proper assertions. No runtime code is modified.
• No files require special attention.

Important Files Changed

Filename	Overview
packages/react-noop-renderer/src/createReactNoop.js	Core change: onRecoverableError now logs to console.error instead of silently swallowing errors, enabling test infrastructure to catch unasserted recoverable errors. Added Flow type annotations.
packages/react-reconciler/src/tests/ReactIncrementalErrorHandling-test.internal.js	Added 4 assertConsoleErrorDev calls to tests that trigger concurrent rendering error recovery, properly asserting the now-surfaced recoverable error messages.
packages/react-reconciler/src/tests/ReactIncrementalErrorReplay-test.js	Added assertConsoleErrorDev import and assertion for the recoverable error in the error replay test.
packages/react-reconciler/src/tests/useMemoCache-test.js	Replaced manual spyOnDev(console, 'error') with proper assertConsoleErrorDev assertion and consolidated internal-test-utils imports into a single destructured require.

_{Last reviewed commit: 1b61b6a}

[greptile-apps]

_{4 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[everettbu]

Upstream PR was closed or merged. Code is synced via branch mirror.