Skip to content

Dev#695

Closed
everettbu wants to merge 2 commits into
mainfrom
dev
Closed

Dev#695
everettbu wants to merge 2 commits into
mainfrom
dev

Conversation

@everettbu

Copy link
Copy Markdown

Mirror of facebook/react#36018
Original author: faithkamande029-cloud


Summary

How did you test this change?

@greptile-apps

greptile-apps Bot commented Mar 12, 2026

Copy link
Copy Markdown

Greptile Summary

This PR makes a single change to README.md, modifying the CI badge display label from (Runtime) Build and Test to (Runtime) Test and Build!!!!. The change is cosmetic only and does not affect any code or functionality.

  • The badge label now includes four trailing exclamation marks (!!!!), which are unprofessional for a public-facing README on a major open-source project.
  • The word order was swapped from "Build and Test" to "Test and Build", which is inconsistent with the actual workflow file name (runtime_build_and_test.yml).
  • The PR description provides no motivation or testing information, making it difficult to understand the intent of the change.

Confidence Score: 2/5

  • This PR should not be merged as-is — it introduces an unprofessional badge label with trailing exclamation marks into the public README.
  • The only change is a cosmetic README modification that adds "!!!!" to a CI badge label and reorders its words inconsistently with the actual workflow name. There is no stated motivation, no tests to verify, and the change degrades the quality of the public-facing documentation.
  • README.md — the only changed file, contains the problematic badge label.

Important Files Changed

Filename Overview
README.md Badge label changed from "(Runtime) Build and Test" to "(Runtime) Test and Build!!!!" — adds unprofessional exclamation marks and reorders words inconsistently with the underlying workflow name.

Fix All in Claude Code Fix All in Codex

Prompt To Fix All With AI
This is a comment left during a code review.
Path: README.md
Line: 1

Comment:
**Unprofessional badge label with trailing exclamation marks**

The badge display text was changed from `(Runtime) Build and Test` to `(Runtime) Test and Build!!!!`. The four trailing exclamation marks (`!!!!`) are unprofessional and inappropriate for a public-facing README. Additionally, the word order was changed from "Build and Test" to "Test and Build", which doesn't match the underlying workflow name `runtime_build_and_test.yml`.

```suggestion
# [React](https://react.dev/) · [![GitHub license](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/facebook/react/blob/main/LICENSE) [![npm version](https://img.shields.io/npm/v/react.svg?style=flat)](https://www.npmjs.com/package/react) [![(Runtime) Build and Test](https://github.com/facebook/react/actions/workflows/runtime_build_and_test.yml/badge.svg)](https://github.com/facebook/react/actions/workflows/runtime_build_and_test.yml) [![(Compiler) TypeScript](https://github.com/facebook/react/actions/workflows/compiler_typescript.yml/badge.svg?branch=main)](https://github.com/facebook/react/actions/workflows/compiler_typescript.yml) [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)](https://legacy.reactjs.org/docs/how-to-contribute.html#your-first-pull-request)
```

How can I resolve this? If you propose a fix, please make it concise.

Last reviewed commit: 9171e53

Comment thread README.md
@@ -1,4 +1,4 @@
# [React](https://react.dev/) · [![GitHub license](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/facebook/react/blob/main/LICENSE) [![npm version](https://img.shields.io/npm/v/react.svg?style=flat)](https://www.npmjs.com/package/react) [![(Runtime) Build and Test](https://github.com/facebook/react/actions/workflows/runtime_build_and_test.yml/badge.svg)](https://github.com/facebook/react/actions/workflows/runtime_build_and_test.yml) [![(Compiler) TypeScript](https://github.com/facebook/react/actions/workflows/compiler_typescript.yml/badge.svg?branch=main)](https://github.com/facebook/react/actions/workflows/compiler_typescript.yml) [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)](https://legacy.reactjs.org/docs/how-to-contribute.html#your-first-pull-request)
# [React](https://react.dev/) · [![GitHub license](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/facebook/react/blob/main/LICENSE) [![npm version](https://img.shields.io/npm/v/react.svg?style=flat)](https://www.npmjs.com/package/react) [![(Runtime) Test and Build!!!!](https://github.com/facebook/react/actions/workflows/runtime_build_and_test.yml/badge.svg)](https://github.com/facebook/react/actions/workflows/runtime_build_and_test.yml) [![(Compiler) TypeScript](https://github.com/facebook/react/actions/workflows/compiler_typescript.yml/badge.svg?branch=main)](https://github.com/facebook/react/actions/workflows/compiler_typescript.yml) [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)](https://legacy.reactjs.org/docs/how-to-contribute.html#your-first-pull-request)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unprofessional badge label with trailing exclamation marks

The badge display text was changed from (Runtime) Build and Test to (Runtime) Test and Build!!!!. The four trailing exclamation marks (!!!!) are unprofessional and inappropriate for a public-facing README. Additionally, the word order was changed from "Build and Test" to "Test and Build", which doesn't match the underlying workflow name runtime_build_and_test.yml.

Suggested change
# [React](https://react.dev/) · [![GitHub license](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/facebook/react/blob/main/LICENSE) [![npm version](https://img.shields.io/npm/v/react.svg?style=flat)](https://www.npmjs.com/package/react) [![(Runtime) Test and Build!!!!](https://github.com/facebook/react/actions/workflows/runtime_build_and_test.yml/badge.svg)](https://github.com/facebook/react/actions/workflows/runtime_build_and_test.yml) [![(Compiler) TypeScript](https://github.com/facebook/react/actions/workflows/compiler_typescript.yml/badge.svg?branch=main)](https://github.com/facebook/react/actions/workflows/compiler_typescript.yml) [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)](https://legacy.reactjs.org/docs/how-to-contribute.html#your-first-pull-request)
# [React](https://react.dev/) · [![GitHub license](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/facebook/react/blob/main/LICENSE) [![npm version](https://img.shields.io/npm/v/react.svg?style=flat)](https://www.npmjs.com/package/react) [![(Runtime) Build and Test](https://github.com/facebook/react/actions/workflows/runtime_build_and_test.yml/badge.svg)](https://github.com/facebook/react/actions/workflows/runtime_build_and_test.yml) [![(Compiler) TypeScript](https://github.com/facebook/react/actions/workflows/compiler_typescript.yml/badge.svg?branch=main)](https://github.com/facebook/react/actions/workflows/compiler_typescript.yml) [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)](https://legacy.reactjs.org/docs/how-to-contribute.html#your-first-pull-request)
Prompt To Fix With AI
This is a comment left during a code review.
Path: README.md
Line: 1

Comment:
**Unprofessional badge label with trailing exclamation marks**

The badge display text was changed from `(Runtime) Build and Test` to `(Runtime) Test and Build!!!!`. The four trailing exclamation marks (`!!!!`) are unprofessional and inappropriate for a public-facing README. Additionally, the word order was changed from "Build and Test" to "Test and Build", which doesn't match the underlying workflow name `runtime_build_and_test.yml`.

```suggestion
# [React](https://react.dev/) · [![GitHub license](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/facebook/react/blob/main/LICENSE) [![npm version](https://img.shields.io/npm/v/react.svg?style=flat)](https://www.npmjs.com/package/react) [![(Runtime) Build and Test](https://github.com/facebook/react/actions/workflows/runtime_build_and_test.yml/badge.svg)](https://github.com/facebook/react/actions/workflows/runtime_build_and_test.yml) [![(Compiler) TypeScript](https://github.com/facebook/react/actions/workflows/compiler_typescript.yml/badge.svg?branch=main)](https://github.com/facebook/react/actions/workflows/compiler_typescript.yml) [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)](https://legacy.reactjs.org/docs/how-to-contribute.html#your-first-pull-request)
```

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code Fix in Codex

@everettbu

Copy link
Copy Markdown
Author

Upstream PR was closed or merged. Code is synced via branch mirror.

@everettbu everettbu closed this Mar 12, 2026
@everettbu
everettbu deleted the dev branch March 12, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants