[rcr, Flight] Add throwing RSC entrypoint for compiler-runtime#75
Open
everettbu wants to merge 3 commits into
Open
[rcr, Flight] Add throwing RSC entrypoint for compiler-runtime#75everettbu wants to merge 3 commits into
everettbu wants to merge 3 commits into
Conversation
Greptile OverviewGreptile SummaryAdded throwing RSC (React Server Components) entrypoints for
All changes are well-structured and consistent with React's architecture. The error messages are clear and actionable. Confidence Score: 5/5
Important Files ChangedFile Analysis
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of facebook/react#32056
Original author: eps1lon
Summary
Alternate to react/react#29057
Closes react/react#31702
Adds a throwing stub to
react-compiler-runtimeandreact/compiler-runtimeif thereact-serverimport condition is set that throw:For
react-compiler-runtimeI had to addexportsso this is technically a breaking change. Though I think we consider this only to be used as a Compiler target so anyreact-compiler-runtime/dist/*orreact-compiler-runtime/src/*imports are already out of SemVer guarantees I guess?How did you test this change?
Tested
react/compiler-runtimewith CSB artifacts merged with a localyarn build react-compiler-runtime.react-server,react/compiler-runtimereact-compiler-runtimeI just manually checked thatdist/is as expected: