[wip] Replace LegacyHidden with Activity mode#80
Draft
everettbu wants to merge 2 commits into
Draft
Conversation
everettbu
added
CLA Signed
React Core Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of facebook/react#32507
Original author: rickhanlonii
Based off PR: react/react#32499
There's a comment in the code added in this commit that we should replace LegacyHidden with an Activity
mode:https://github.com/facebook/react/blob/54fdb2f71810ef78c355108c219822ba097de8b3/packages/react-server/src/ReactFizzServer.js#L2253-L2255
This PR is an example of what that could look like, but it also exposes how difficult it is in the current model to add different modes with different behaviors. We could merge this, get on this version, and then iterate and improve.
Or we could just use this as an example to figure out the right model and layering.
Note: this kinda just ignores the view transition stuff for the legacy modes.