Make skills dual-compatible with Pi / the open-skills ecosystem#20
Open
hawkff wants to merge 2 commits into
Open
Make skills dual-compatible with Pi / the open-skills ecosystem#20hawkff wants to merge 2 commits into
hawkff wants to merge 2 commits into
Conversation
- Add metadata.triggers regex arrays to check-pr, greploop, and cli-review so intent-based agents (e.g. Pi) auto-invoke them - Add top-level .claude-plugin/plugin.json declaring the three skills for open-skills CLI indexing - Document npx skills install path and intent-based invocation in README All changes are additive; existing Claude Code keys (allowed-tools, compatibility) and the symlink install flow are preserved.
…cing Address Greptile review notes on PR #1: - README: distinguish the skills.sh CLI from the agentskills.io spec - cli-review: move the space inside the optional group so 'run greptile my branch' matches (no dangling double space)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make skills dual-compatible with Pi / the open-skills ecosystem
Summary
These skills are authored for Claude Code. The instruction bodies are already
agent-agnostic, but the packaging and docs assume Claude's discovery model, so
agents that use the open Agent Skills standard (e.g.
Pi) get a degraded experience: a misleading install flow and no catalog
manifest.
This PR makes the repo dual-compatible with additive changes only.
Nothing Claude-specific is removed — existing
allowed-tools,compatibilityfrontmatter, and the
~/.claude/skillssymlink install flow are untouched.What changed
.claude-plugin/plugin.json(new) — declares the three skills(
check-pr,greploop,cli-review) so the openskillsCLI / catalogs canindex the multi-skill repo.
(
npx skills add greptileai/skills) next to the existing Claude flow, plus aPi usage section explaining progressive-disclosure activation (via the
descriptionfield) and the explicit/skill:namecommand.metadata.triggersadded to eachSKILL.mdas optional catalog hints fortooling that indexes skills. These are arbitrary metadata; agents that don't
use them simply ignore them.
Why
~/.claude/skills+ manualln -s) don'tapply to open-skills agents, which install directly from the repo and track
installs in a
skills-lock.json. The multi-skill layout already exposes eachskill at
<skill>/SKILL.md, so per-skill installs work without symlinks.repo that ships more than one skill.
Compatibility
npx skills add greptileai/skills, and the docscorrectly describe how activation works (description-driven, with
/skill:namefor explicit invocation).
Notes / accuracy
The README is careful not to overstate the mechanism: on Pi, skill
activation is driven by the
descriptionfield (progressive disclosure), not bymetadata.triggers. Thetriggersare documented purely as optional indexinghints.
Testing
metadata.triggersregexes compile cleanly (7 + 7 + 5)..claude-plugin/plugin.jsonis valid JSON and every referenced<skill>/SKILL.mdpath exists.npx skills add greptileai/skills/<skill>.Out of scope
No changes to skill instructions, the
references/API docs, or the LICENSE.