Skip to content

Small QoL improvements to MFA#2537

Open
everettbu wants to merge 2 commits into
masterfrom
chore/small-qol-improvements-to-mfa
Open

Small QoL improvements to MFA#2537
everettbu wants to merge 2 commits into
masterfrom
chore/small-qol-improvements-to-mfa

Conversation

@everettbu

Copy link
Copy Markdown

Mirror of supabase/supabase#43861
Original author: joshenlim


Context

Resolves FE-2794

Just addressing some friction points i ran into when setting up MFA for my account under account preferences

Changes involved

  • Hitting enter at each step of setting up MFA will submit and proceed (Previously didn't, had to click buttons)
  • When logging in with MFA, automatically submit after entering 6 digits
  • Refactored to use react hook form for AddNewFactorModal in FirstStep and SecondStep + simplified the logic a little

@github-actions

github-actions Bot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

🎭 Playwright Test Results

passed  156 passed
flaky  1 flaky
skipped  5 skipped

Details

stats  162 tests across 20 suites
duration  2 minutes, 31 seconds
commit  971e2a5

Flaky tests

Features › table-editor.spec.ts › table editor › filtering rows works as expected

Skipped tests

Features › assistant.spec.ts › AI Assistant › Can send a message to the assistant and receive a response
Features › sql-editor.spec.ts › SQL Editor › snippet favourite works as expected
Features › sql-editor.spec.ts › SQL Editor › share with team works as expected
Features › sql-editor.spec.ts › SQL Editor › folders works as expected
Features › sql-editor.spec.ts › SQL Editor › other SQL snippets actions work as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants