Change NodeGroup server selection behavior towards dedicated pool label #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP add some logs wip wip wip wip wip wip wip wip fix finishFunc only runs for last node in slice fix maxNodeCount < minNodeCount wip wip wip Revert "wip" This reverts commit 94ffbf6. make GRIDSCALE_GSK_MIN_NODE_COUNT optional stop the autoscaler main loop when gsk not active change namespace to gsk-autoscaler remove dummy logs update readmen and FAQ make gridscale default provider add gridscale autoscale release gh action fix gsk release gh action use ref_name instead of ref fix gsk release gh action wip wip don't skip tainting gridscale k8s node0 remove node selection Revert "don't skip tainting gridscale k8s node0" This reverts commit 3007872. rename GRIDSCALE_GSK_* to CLUSTER_* change GRIDSCALE_* to API_* add README for gridscale format gridscale readme disable daemonset-eviction
nodesToDeleteCount need to be the one for the current node group. Not the whole cluster.
It seems we have no use for this new value in our custom deletion logic.
This is to show there is a bug in the implementation. The filter on the server labels does not cover a given edge case.
- Add test for master server - Add test for servers without pool name label - Add pool name labels to NodeGroup tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of the new server label
#gsk-pool#which will be part of all worker nodes provisioined in 1.31 clusters.The goal with this is to avoid an edge case which could happen if pools with names like
pool0andpool01are used. See the added unit tests which cover that edge case.This PR is stacked on top of #2