fix(aggrid): debounce in text custom filters #3573
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joris Mancini <[email protected]>
TheMaskedTurtle
force-pushed
the
jorism/fix/debounce-aggrid-filters
branch
from
4ffec91 to
f1487f4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
That fixes the debounce issue within custom aggrid filter component. The problem is that we linked the value displayed with the actual value used for filtering. We want to debounce the filtering operation because it is costly, but we don't want to debounce the displayed value. Then, we have to separate variables. The problem is that we still need to update the content of the filter component if it has been changed in another tab of the study (updated in redux). We can maybe accept a compromise where there are absolutely no glitches in the filter component but, if we have two opened filter component on the same study with two tabs it won't be up-to-date. When we close the filter component and re-open it would be up-to-date again.