Added the ability to add related sources#1219
Open
ldhtnp wants to merge 15 commits into
Open
Conversation
susannasiebert
requested changes
Apr 1, 2025
susannasiebert
left a comment
Contributor
There was a problem hiding this comment.
I left some comments about some design decisions that may need some further thought. There are also some things I noticed when trying out the new form:

- The icon in the form header needs to be changed to the source icon
- The placement of the "Add a related source" button is not ideal. That space is generally reserved for general actions related to this type of entity while action for a specific entity would appear where the pubmed linkout currently is
- The cancel button is positioned on top of the submit button instead of next to it
There is currently no way to view source links as far as I can tell. Depending on wether we decide that directionality is important we should show both the sources that are linked to the current source as well as the sources that have linked the current source to them (basically you want to be able to see the same link from either source).
We should also think about whether we need some ability to delete source linkages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to essentially link related sources together. When logged in, a button to do so appears next to the existing "Suggest a New Source" button.
More information can be found in issue #1196