Skip to content

Add support of framework Accelerate for MacOS #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
foxtran wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add support of framework Accelerate for MacOS #1371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9c4fbaa
Add CMake support of Apple Accelerate
foxtran Dec 14, 2025
c4830a4
Add accelerate option
foxtran Dec 14, 2025
ed6191f
Add tests for CMake
foxtran Dec 14, 2025
fd50361
Disable broken tests
foxtran Dec 14, 2025
e12ff43
Add related issues
foxtran Dec 15, 2025
b1efa91
Drop accelerate for meson
foxtran Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/fortran-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,24 @@ jobs:
fc: [gfortran-14]
cc: [gcc-14]
build: [Release, Debug]
include:
- os: macos-15-intel
fc: gfortran-15
cc: gcc-15
build: Release
- os: macos-latest
fc: gfortran-14
cc: gcc-14
build: Release
# Illegal instructions for xtb/gfn2 (https://github.com/grimme-lab/xtb/issues/1372), xtb/ptb (https://github.com/grimme-lab/xtb/issues/1373) tests
# - os: macos-latest
# fc: gfortran-15
# cc: gcc-15
# build: Debug
- os: macos-latest
fc: gfortran-15
cc: gcc-15
build: Release
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down
7 changes: 7 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,13 @@ endif()
find_package("LAPACK" REQUIRED)
find_package("BLAS" REQUIRED)

if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
if("${BLAS_LIBRARIES}" MATCHES "Accelerate\\.framework")
include(cmake/DarwinAccelerateAliases.cmake)
apply_framework_accelerate_aliases()
endif()
endif()


if(NOT EXISTS "${PROJECT_BINARY_DIR}/include")
file(MAKE_DIRECTORY "${PROJECT_BINARY_DIR}/include")
Expand Down
88 changes: 88 additions & 0 deletions cmake/DarwinAccelerateAliases.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
# One has to mask old buggy implementation of BLAS/LAPACK from Apple Accelerate with fixed version.
# New implementation is available since MacOS 13.3, and has suffix $NEWLAPACK for LP64 mode, ILP64 mode has syffix $NEWLAPACK$ILP64.
# Note, new implementation still has incompatible interface for cdotc, cdotu, zdotc, zdotu. Fortunately, xtb does not use them (yet).
# We apply these aliases for all targets. Better solution is to provide explicit interfaces in source code.
function(apply_framework_accelerate_aliases)
add_link_options("-Wl,-alias,_dasum$NEWLAPACK,_dasum_")
add_link_options("-Wl,-alias,_daxpy$NEWLAPACK,_daxpy_")
add_link_options("-Wl,-alias,_dcopy$NEWLAPACK,_dcopy_")
add_link_options("-Wl,-alias,_ddot$NEWLAPACK,_ddot_")
add_link_options("-Wl,-alias,_dgemm$NEWLAPACK,_dgemm_")
add_link_options("-Wl,-alias,_dgemv$NEWLAPACK,_dgemv_")
add_link_options("-Wl,-alias,_dger$NEWLAPACK,_dger_")
add_link_options("-Wl,-alias,_dgetrf$NEWLAPACK,_dgetrf_")
add_link_options("-Wl,-alias,_dgetri$NEWLAPACK,_dgetri_")
add_link_options("-Wl,-alias,_dgetrs$NEWLAPACK,_dgetrs_")
add_link_options("-Wl,-alias,_dnrm2$NEWLAPACK,_dnrm2_")
add_link_options("-Wl,-alias,_dpotrf$NEWLAPACK,_dpotrf_")
add_link_options("-Wl,-alias,_dpotrs$NEWLAPACK,_dpotrs_")
add_link_options("-Wl,-alias,_dpptrf$NEWLAPACK,_dpptrf_")
add_link_options("-Wl,-alias,_dpptrs$NEWLAPACK,_dpptrs_")
add_link_options("-Wl,-alias,_drot$NEWLAPACK,_drot_")
add_link_options("-Wl,-alias,_dscal$NEWLAPACK,_dscal_")
add_link_options("-Wl,-alias,_dspev$NEWLAPACK,_dspev_")
add_link_options("-Wl,-alias,_dspevd$NEWLAPACK,_dspevd_")
add_link_options("-Wl,-alias,_dspmv$NEWLAPACK,_dspmv_")
add_link_options("-Wl,-alias,_dspr2$NEWLAPACK,_dspr2_")
add_link_options("-Wl,-alias,_dspr$NEWLAPACK,_dspr_")
add_link_options("-Wl,-alias,_dsptrf$NEWLAPACK,_dsptrf_")
add_link_options("-Wl,-alias,_dsptrs$NEWLAPACK,_dsptrs_")
add_link_options("-Wl,-alias,_dswap$NEWLAPACK,_dswap_")
add_link_options("-Wl,-alias,_dsyev$NEWLAPACK,_dsyev_")
add_link_options("-Wl,-alias,_dsyevd$NEWLAPACK,_dsyevd_")
add_link_options("-Wl,-alias,_dsygst$NEWLAPACK,_dsygst_")
add_link_options("-Wl,-alias,_dsygvd$NEWLAPACK,_dsygvd_")
add_link_options("-Wl,-alias,_dsymm$NEWLAPACK,_dsymm_")
add_link_options("-Wl,-alias,_dsymv$NEWLAPACK,_dsymv_")
add_link_options("-Wl,-alias,_dsyr2$NEWLAPACK,_dsyr2_")
add_link_options("-Wl,-alias,_dsyr2k$NEWLAPACK,_dsyr2k_")
add_link_options("-Wl,-alias,_dsyr$NEWLAPACK,_dsyr_")
add_link_options("-Wl,-alias,_dsyrk$NEWLAPACK,_dsyrk_")
add_link_options("-Wl,-alias,_dsysv$NEWLAPACK,_dsysv_")
add_link_options("-Wl,-alias,_dsytrf$NEWLAPACK,_dsytrf_")
add_link_options("-Wl,-alias,_dsytri$NEWLAPACK,_dsytri_")
add_link_options("-Wl,-alias,_dsytrs$NEWLAPACK,_dsytrs_")
add_link_options("-Wl,-alias,_dtrmm$NEWLAPACK,_dtrmm_")
add_link_options("-Wl,-alias,_dtrsm$NEWLAPACK,_dtrsm_")
add_link_options("-Wl,-alias,_idamax$NEWLAPACK,_idamax_")
add_link_options("-Wl,-alias,_isamax$NEWLAPACK,_isamax_")
add_link_options("-Wl,-alias,_sasum$NEWLAPACK,_sasum_")
add_link_options("-Wl,-alias,_saxpy$NEWLAPACK,_saxpy_")
add_link_options("-Wl,-alias,_scopy$NEWLAPACK,_scopy_")
add_link_options("-Wl,-alias,_sdot$NEWLAPACK,_sdot_")
add_link_options("-Wl,-alias,_sgemm$NEWLAPACK,_sgemm_")
add_link_options("-Wl,-alias,_sgemv$NEWLAPACK,_sgemv_")
add_link_options("-Wl,-alias,_sger$NEWLAPACK,_sger_")
add_link_options("-Wl,-alias,_sgetrf$NEWLAPACK,_sgetrf_")
add_link_options("-Wl,-alias,_sgetrs$NEWLAPACK,_sgetrs_")
add_link_options("-Wl,-alias,_snrm2$NEWLAPACK,_snrm2_")
add_link_options("-Wl,-alias,_spotrf$NEWLAPACK,_spotrf_")
add_link_options("-Wl,-alias,_spotrs$NEWLAPACK,_spotrs_")
add_link_options("-Wl,-alias,_spptrf$NEWLAPACK,_spptrf_")
add_link_options("-Wl,-alias,_spptrs$NEWLAPACK,_spptrs_")
add_link_options("-Wl,-alias,_srot$NEWLAPACK,_srot_")
add_link_options("-Wl,-alias,_sscal$NEWLAPACK,_sscal_")
add_link_options("-Wl,-alias,_sspevx$NEWLAPACK,_sspevx_")
add_link_options("-Wl,-alias,_sspmv$NEWLAPACK,_sspmv_")
add_link_options("-Wl,-alias,_sspr2$NEWLAPACK,_sspr2_")
add_link_options("-Wl,-alias,_sspr$NEWLAPACK,_sspr_")
add_link_options("-Wl,-alias,_ssptrf$NEWLAPACK,_ssptrf_")
add_link_options("-Wl,-alias,_ssptrs$NEWLAPACK,_ssptrs_")
add_link_options("-Wl,-alias,_sswap$NEWLAPACK,_sswap_")
add_link_options("-Wl,-alias,_ssyev$NEWLAPACK,_ssyev_")
add_link_options("-Wl,-alias,_ssyevd$NEWLAPACK,_ssyevd_")
add_link_options("-Wl,-alias,_ssyevx$NEWLAPACK,_ssyevx_")
add_link_options("-Wl,-alias,_ssygst$NEWLAPACK,_ssygst_")
add_link_options("-Wl,-alias,_ssygvd$NEWLAPACK,_ssygvd_")
add_link_options("-Wl,-alias,_ssymm$NEWLAPACK,_ssymm_")
add_link_options("-Wl,-alias,_ssymv$NEWLAPACK,_ssymv_")
add_link_options("-Wl,-alias,_ssyr2$NEWLAPACK,_ssyr2_")
add_link_options("-Wl,-alias,_ssyr2k$NEWLAPACK,_ssyr2k_")
add_link_options("-Wl,-alias,_ssyr$NEWLAPACK,_ssyr_")
add_link_options("-Wl,-alias,_ssyrk$NEWLAPACK,_ssyrk_")
add_link_options("-Wl,-alias,_ssytrf$NEWLAPACK,_ssytrf_")
add_link_options("-Wl,-alias,_ssytri$NEWLAPACK,_ssytri_")
add_link_options("-Wl,-alias,_ssytrs$NEWLAPACK,_ssytrs_")
add_link_options("-Wl,-alias,_strmm$NEWLAPACK,_strmm_")
add_link_options("-Wl,-alias,_strsm$NEWLAPACK,_strsm_")
endfunction()
93 changes: 93 additions & 0 deletions meson/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,99 @@ elif lapack_vendor == 'openblas'
lib_deps += lapack_dep
endif

elif lapack_vendor == 'accelerate'
accelerate_dep = dependency('accelerate')
# See cmake/DarwinAccelerateAliases.cmake
link_aliases = [
'-Wl,-alias,_dasum$NEWLAPACK,_dasum_',
'-Wl,-alias,_daxpy$NEWLAPACK,_daxpy_',
'-Wl,-alias,_dcopy$NEWLAPACK,_dcopy_',
'-Wl,-alias,_ddot$NEWLAPACK,_ddot_',
'-Wl,-alias,_dgemm$NEWLAPACK,_dgemm_',
'-Wl,-alias,_dgemv$NEWLAPACK,_dgemv_',
'-Wl,-alias,_dger$NEWLAPACK,_dger_',
'-Wl,-alias,_dgetrf$NEWLAPACK,_dgetrf_',
'-Wl,-alias,_dgetri$NEWLAPACK,_dgetri_',
'-Wl,-alias,_dgetrs$NEWLAPACK,_dgetrs_',
'-Wl,-alias,_dnrm2$NEWLAPACK,_dnrm2_',
'-Wl,-alias,_dpotrf$NEWLAPACK,_dpotrf_',
'-Wl,-alias,_dpotrs$NEWLAPACK,_dpotrs_',
'-Wl,-alias,_dpptrf$NEWLAPACK,_dpptrf_',
'-Wl,-alias,_dpptrs$NEWLAPACK,_dpptrs_',
'-Wl,-alias,_drot$NEWLAPACK,_drot_',
'-Wl,-alias,_dscal$NEWLAPACK,_dscal_',
'-Wl,-alias,_dspev$NEWLAPACK,_dspev_',
'-Wl,-alias,_dspevd$NEWLAPACK,_dspevd_',
'-Wl,-alias,_dspmv$NEWLAPACK,_dspmv_',
'-Wl,-alias,_dspr2$NEWLAPACK,_dspr2_',
'-Wl,-alias,_dspr$NEWLAPACK,_dspr_',
'-Wl,-alias,_dsptrf$NEWLAPACK,_dsptrf_',
'-Wl,-alias,_dsptrs$NEWLAPACK,_dsptrs_',
'-Wl,-alias,_dswap$NEWLAPACK,_dswap_',
'-Wl,-alias,_dsyev$NEWLAPACK,_dsyev_',
'-Wl,-alias,_dsyevd$NEWLAPACK,_dsyevd_',
'-Wl,-alias,_dsygst$NEWLAPACK,_dsygst_',
'-Wl,-alias,_dsygvd$NEWLAPACK,_dsygvd_',
'-Wl,-alias,_dsymm$NEWLAPACK,_dsymm_',
'-Wl,-alias,_dsymv$NEWLAPACK,_dsymv_',
'-Wl,-alias,_dsyr2$NEWLAPACK,_dsyr2_',
'-Wl,-alias,_dsyr2k$NEWLAPACK,_dsyr2k_',
'-Wl,-alias,_dsyr$NEWLAPACK,_dsyr_',
'-Wl,-alias,_dsyrk$NEWLAPACK,_dsyrk_',
'-Wl,-alias,_dsysv$NEWLAPACK,_dsysv_',
'-Wl,-alias,_dsytrf$NEWLAPACK,_dsytrf_',
'-Wl,-alias,_dsytri$NEWLAPACK,_dsytri_',
'-Wl,-alias,_dsytrs$NEWLAPACK,_dsytrs_',
'-Wl,-alias,_dtrmm$NEWLAPACK,_dtrmm_',
'-Wl,-alias,_dtrsm$NEWLAPACK,_dtrsm_',
'-Wl,-alias,_idamax$NEWLAPACK,_idamax_',
'-Wl,-alias,_isamax$NEWLAPACK,_isamax_',
'-Wl,-alias,_sasum$NEWLAPACK,_sasum_',
'-Wl,-alias,_saxpy$NEWLAPACK,_saxpy_',
'-Wl,-alias,_scopy$NEWLAPACK,_scopy_',
'-Wl,-alias,_sdot$NEWLAPACK,_sdot_',
'-Wl,-alias,_sgemm$NEWLAPACK,_sgemm_',
'-Wl,-alias,_sgemv$NEWLAPACK,_sgemv_',
'-Wl,-alias,_sger$NEWLAPACK,_sger_',
'-Wl,-alias,_sgetrf$NEWLAPACK,_sgetrf_',
'-Wl,-alias,_sgetrs$NEWLAPACK,_sgetrs_',
'-Wl,-alias,_snrm2$NEWLAPACK,_snrm2_',
'-Wl,-alias,_spotrf$NEWLAPACK,_spotrf_',
'-Wl,-alias,_spotrs$NEWLAPACK,_spotrs_',
'-Wl,-alias,_spptrf$NEWLAPACK,_spptrf_',
'-Wl,-alias,_spptrs$NEWLAPACK,_spptrs_',
'-Wl,-alias,_srot$NEWLAPACK,_srot_',
'-Wl,-alias,_sscal$NEWLAPACK,_sscal_',
'-Wl,-alias,_sspevx$NEWLAPACK,_sspevx_',
'-Wl,-alias,_sspmv$NEWLAPACK,_sspmv_',
'-Wl,-alias,_sspr2$NEWLAPACK,_sspr2_',
'-Wl,-alias,_sspr$NEWLAPACK,_sspr_',
'-Wl,-alias,_ssptrf$NEWLAPACK,_ssptrf_',
'-Wl,-alias,_ssptrs$NEWLAPACK,_ssptrs_',
'-Wl,-alias,_sswap$NEWLAPACK,_sswap_',
'-Wl,-alias,_ssyev$NEWLAPACK,_ssyev_',
'-Wl,-alias,_ssyevd$NEWLAPACK,_ssyevd_',
'-Wl,-alias,_ssyevx$NEWLAPACK,_ssyevx_',
'-Wl,-alias,_ssygst$NEWLAPACK,_ssygst_',
'-Wl,-alias,_ssygvd$NEWLAPACK,_ssygvd_',
'-Wl,-alias,_ssymm$NEWLAPACK,_ssymm_',
'-Wl,-alias,_ssymv$NEWLAPACK,_ssymv_',
'-Wl,-alias,_ssyr2$NEWLAPACK,_ssyr2_',
'-Wl,-alias,_ssyr2k$NEWLAPACK,_ssyr2k_',
'-Wl,-alias,_ssyr$NEWLAPACK,_ssyr_',
'-Wl,-alias,_ssyrk$NEWLAPACK,_ssyrk_',
'-Wl,-alias,_ssytrf$NEWLAPACK,_ssytrf_',
'-Wl,-alias,_ssytri$NEWLAPACK,_ssytri_',
'-Wl,-alias,_ssytrs$NEWLAPACK,_ssytrs_',
'-Wl,-alias,_strmm$NEWLAPACK,_strmm_',
'-Wl,-alias,_strsm$NEWLAPACK,_strsm_',
]
link_aliases_dep = declare_dependency(
link_args: link_aliases,
)
lib_deps += accelerate_dep
lib_deps += link_aliases_dep

elif lapack_vendor == 'custom'
custom_deps = []
libs = get_option('custom_libraries')
Expand Down
Loading