Merge pull request #121 from imbus/rename-testcases

Rename testcases

Author: cz-lucas

app/Models/PredefinedFilter.php

@@ -86,8 +86,7 @@ public function userHasPermission(User $user, string $action): bool
 
             default:
                 return false;
-        }
-        // end switch
+        } // end switch
     }
 
     private function checkPermissions(User $user, $action): bool

app/Services/FilterService/FilterService.php

@@ -400,7 +400,7 @@ protected function applyLogic($logic, $q, $callback, $fieldname){
      * @param bool    $isDateTime
      */
 
-    public function applyDateRangeFilter($query, $qualifiedField, $filters, bool $isDateTime = false)
+    public function applyDateRangeFilter($query, $qualifiedField, $filters, bool $isDateTime=false)
     {
         $start = null;
         $end = null;

app/Services/PredefinedFilterService.php

@@ -124,8 +124,7 @@ public function getFilterWithIdAndNameValues(int $id)
                             break;
                         default:
                             break;
-                    }
-                    // end switch
+                    } // end switch
 
                     if ($model) {
                         $values[] = [
@@ -207,7 +206,7 @@ public function deleteFilter(PredefinedFilter $filter): ?bool
         return $filter->delete();
     }
 
-    public function selectList(Request $request, bool $visibilityInName = false): LengthAwarePaginator
+    public function selectList(Request $request, bool $visibilityInName=false): LengthAwarePaginator
     {
         $user = Auth::user();
 

resources/assets/js/advancedSearch/filterFormManager.js

@@ -11,7 +11,7 @@ export default class FilterFormManager {
     constructor() {
         this.filters = [];
         this.inputs = [];
-        this.apiService = container.resolve("apiService");;
+        this.apiService = container.resolve("apiService");
     }
 
     async collectFilterInputs() {

resources/assets/js/advancedSearch/floating-buttons.js

@@ -133,7 +133,7 @@ export default class FloatingButtons {
             document.addEventListener('keydown', (e) => {
                 if (e.key === 'Escape') {
                     this.closeMenu();
-                    try { this.menuToggleButton.focus(); } catch (err) { }
+                    try { this.menuToggleButton.focus(); } catch (err) { /* empty */ }
                 }
             });
 
@@ -384,7 +384,7 @@ export default class FloatingButtons {
 
                     this.menuItems?.forEach(item => item.setAttribute('tabindex', '-1'));
                 }
-            } catch { };
+            } catch { /* empty */ }
         });
     }
 

tests/Feature/NotificationsComponentTest.php

@@ -94,7 +94,7 @@ public function testLegacySessionInfoNotificationIsRendered()
             ->assertSee(values: 'alert-info');
     }
 
-    public function testLegacySessionBulk_AssetErrorsAreRendered()
+    public function testLegacySessionBulkAssetErrorsAreRendered()
     {
         Session::flash('bulk_asset_errors', [
             'row1' => ['Missing tag'],