-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Added Daily depreciation calculations for assets and reports #13206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Godmartinz I have a few outstanding questions/comments here, and it looks like we have merge conflicts now - can you peep this one more time? Thanks! |
Alignment fixed, conflicts resolved. |
@snipe anything else that needs to be done here? |
Just my question above: |
Ping @Godmartinz |
@snipe The selector that was being used was only the first class in the group needed. I've updated the css selector and checked other forms. this only affects the depreciation months select, as intended. |
# Conflicts: # app/Http/Transformers/DepreciationReportTransformer.php # resources/lang/iu-NU/admin/hardware/table.php
@uberbrady @snipe conflicts resolved, just need to get tests in order |
Fixed Depreciation Tests
…nto daily_depreciation
Description
This adds the ability to choose daily depreciation as an option for linear depreciation calculations.

On the depreciations report page the column

Number of Months
has been renamedLength of Term
and moved next to theRate of Depreciation
column.On the assets page it will say which unit of depreciation is being used (days/months) on the depreciations row:

List of Depreciations also have a

term_type
column added as well:Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: