-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Added correct counting of licenses seats through pagination #14099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Added correct counting of licenses seats through pagination #14099
Conversation
PR Summary
|
Edit: See comment below Previous comment: I like this but it would be good to handle API requests from outside of our application as well. For example, the requests that the table on the license show page fires has
The But if I add Should we always add |
@snipe if we want to only sort by ascending let me know, I'll edit this PR. But the seat number doesn't really matter for licenses right? |
@Godmartinz asked for clarification about this and I think my overall request makes sense but the implementation would be outside of the scope of this PR. |
Gentle ping, @Godmartinz |
Gentle ping again, @Godmartinz |
whoops missed this, fixing... |
@snipe a check on offset is performed prior to setting the |
Description
The lIcenses seat number would restart if the page was changed. Now licenses seats count continues through pagination
Fixes #14067
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: