Added the option to make Asset serials required and error messages

[Godmartinz]

Description

So this adds a validation rule require_serial. This makes a serial required or nullable based on a boolean in the settings:

adds an error and message for required and unique options being selected if there are serials that are not filled or unique.

Unique error:

Required error:

Fixes #FD-41625

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• [x ] New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A
• Test B

Test Configuration:

• PHP version:
• MySQL version
• Webserver version
• OS version

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[what-the-diff]

PR Summary

• Addition of Required Serial to Settings
  The SettingsController now includes a parameter $setting->required_serial to its postSettings method. This helps in identifying whether a serial is needed in the settings.

• Asset Modifications to Incorporate Required Serial
  A parameter $required_serial has been added to the Asset object by way of the __construct method. The impact of this is a new rule can be added for identifying serial based on the value of $required_serial.

• Database Migration for Required Serial
  There's a new migration file 2024_06_24_173857_adds_serial_required_to_settings_table.php introduced. This file is useful as it adds a required_serial column to the settings table, extending its functionality related to serial requirements.

• Language File Expansion for Required Serial
  The language file general.php is now tuned to accommodate new translation keys namely required_serial and require_serial_help_text. End-users will see this as additional localization supports for the required serial configuration.

• Incorporating Required Serial in the View
  The view file general.blade.php has been adapted to include a new form input for the required_serial setting with corresponding label and help text. This enhances the user interface by factoring in a new possible user input for serial requirements.

[marcusmoore]

I think there might be a better implementation. Let me know what you think.

[marcusmoore]

I added a couple comments that don't hold up merging.

One additional thing (that doesn't hold up the PR) is that it would be cool if we had the field do native html validation by adding required to the input tag like we do with Asset Tag:

[Godmartinz]

Added your suggestions @marcusmoore 👍

[marcusmoore]

Looks good 👍🏾 😄

[snipe]

I think we have the settings in a shared view now so this isn't needed, no?

https://github.com/snipe/snipe-it/blob/8eb68d3901dd13e3e631fc4189537941e43bcd2a/app/Http/Middleware/AssetCountForSidebar.php#L29-L34

[snipe]

This looks good - might we want to warn folks here if their existing assets do not meet the required and/or uniqueness constraints?

[Godmartinz]

This looks good - might we want to warn folks here if their existing assets do not meet the required and/or uniqueness constraints?

Have a response for required. I'll add one for uniqueness as well 👍

[snipe]

@Godmartinz sorry, looks like we have some more conflicts here

[Godmartinz]

Conflicts resolved @snipe 👍