Skip to content

Feature: Editing Custom Fields on Checkout #15074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

akemidx
Copy link
Member

@akemidx akemidx commented Jul 11, 2024

Description

The ability to edit custom fields on an asset have been added to the checkout screen.

Screenshot 2024-07-11 at 4 47 44 PM

Fixes # #4805

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

tested on local instance

  • Test A
  • Test B

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0.33
  • OS version: Ventura 13.0

Checklist:

Copy link

what-the-diff bot commented Jul 11, 2024

PR Summary

  • Enhanced Security measures for Asset Checkout
    In the AssetCheckoutController.php, the team has introduced a new layer of security by incorporating logic to encrypt and decrypt specific fields. This only applies when specific conditions are met, like when a field_encrypted flag is active and if the user has admin permissions. Additionally, the logic now also accommodates array inputs for fields.

  • Unnecessary Spaces Removal
    In AssetsController.php, some unnecessary spaces that weren't needed for the code to function correctly were eliminated. This may not change functionalities, but it does make the code look cleaner and more professional.

  • Interface Improvement in Asset Checkout
    In the checkout.blade.php, a new dropdown menu for custom fields has been added to enhance user interaction. There's also new JavaScript code in place to manage the toggle behavior of the dropdown to ensure it functions seamlessly for users.

@akemidx
Copy link
Member Author

akemidx commented Jul 11, 2024

i left that weird line in the Assets Controller, instead of pushing over and over trying to guess what it wants to be.

Copy link
Member

@snipe snipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd want to add that as a checkbox to the field or fieldset within custom fields. Some folks have a loooooot of custom fields, and that could get pretty overwhelming if they only have a few they typically want to update on a checkout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants