-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
FEATURE: Option for Notes to be Required on Asset Checkin/Checkout #15208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
552f90a
required, but not optional
akemidx 3ff1745
setting created
akemidx 0f0baa2
note field optional
akemidx 4e43fa6
Merge remote-tracking branch 'upstream/develop' into feature/sc-26415
akemidx 27c120a
front end changes/updates from gh
akemidx 2901ecb
more test work
akemidx 77c5035
fixing some formatting
akemidx bebb72a
back to having tests pass. needed to comment out the notes rules() i …
akemidx d262638
backend form validation. +cleanup
akemidx 73a059c
missing closing )
akemidx 081c570
required, but not optional
akemidx 700647c
setting created
akemidx 8b643cb
note field optional
akemidx 5e74b10
front end changes/updates from gh
akemidx 515f59f
more test work
akemidx bd6698d
fixing some formatting
akemidx 925aea8
back to having tests pass. needed to comment out the notes rules() i …
akemidx f45b836
backend form validation. +cleanup
akemidx 6fef127
missing closing )
akemidx 17706f1
requested changes
akemidx 492e686
Merge remote-tracking branch 'origin/feature/sc-26415' into feature/s…
akemidx 06e3bb7
requested changes
akemidx e00a1ae
note box is now missing when unchecking setting
akemidx 0c84904
un'required'ing the rule. not sure what's breaking here but looking
akemidx 299e743
weird requesting
akemidx 5cb940c
Merge branch 'refs/heads/upstream/dev' into feature/sc-26415
akemidx f0d3a6e
removing some comments/merging in develop
akemidx 9cb411c
removing required form div container
akemidx dd223fc
commit for testing
akemidx 0d60855
orange bar for requirednessness
akemidx 2727210
requested changes from pr
akemidx a7dae10
fixing line
akemidx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
database/migrations/2024_08_01_201721_add_required_notes_setting.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <?php | ||
|
|
||
| use Illuminate\Database\Migrations\Migration; | ||
| use Illuminate\Database\Schema\Blueprint; | ||
| use Illuminate\Support\Facades\Schema; | ||
|
|
||
| return new class extends Migration | ||
| { | ||
| /** | ||
| * Run the migrations. | ||
| */ | ||
| public function up(): void | ||
| { | ||
| Schema::table('settings', function (Blueprint $table) { | ||
| $table->boolean('require_checkinout_notes')->nullable()->default(0); | ||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * Reverse the migrations. | ||
| */ | ||
| public function down(): void | ||
| { | ||
| Schema::table('settings', function (Blueprint $table) { | ||
| if (Schema::hasColumn('settings', 'require_checkinout_notes')) { | ||
| $table->dropColumn('require_checkinout_notes'); | ||
| } | ||
| }); | ||
| } | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.