Skip to content

Conversation

@Toreg87
Copy link
Contributor

@Toreg87 Toreg87 commented Oct 14, 2024

Description

Commit fb4fe30 restored the previous behaviour to check the company_id in case of FullMultipleCompanySupport.
But after rereading the code and the laravel documentation, the check is already there where it belongs in AssetStoreRequest::prepareForValidation(). The bug is the is_int-check of the request input in prepareForValidation(). Is is of type string even if it is a numeric value, so the call to getIdForCurrentUser() never happend. Fix this by removing the check and the now redundant call to getIdForCurrentUser(). Wrong values will get caught by the model-level validation rules.

@Toreg87 Toreg87 requested a review from snipe as a code owner October 14, 2024 13:00
@what-the-diff
Copy link

what-the-diff bot commented Oct 14, 2024

PR Summary

  • Refined & Optimized Asset Management Logic

    • The assignment of company_id has been removed from AssetsController.php, now utilizing validated request input.
    • The logic within StoreAssetRequest.php has been updated that allows for direct fetching of ID for a user based on company_id.
  • Refactor of Configuration Settings

    • The active branch has been switched from develop to master within config/version.php.
  • Maximized CSS Efficiency Across Various Themes

    • Various elements of the CSS code have been consolidated and compacted across numerous themes (m-signature-pad, .skin-black, skin-blue, skin-contrast, skin-green, skin-orange, skin-purple, skin-red, skin-yellow), resulting in reduced whitespace, comments and file size.
    • Core original styles and responsive settings for mobile view are still preserved across these themes.
    • Thematic color hex codes across files have been updated to lowercase for consistency.
    • Styles for key site elements such as navbar, sidebar, and buttons have been streamlined across skins.
  • Update in Resource Version IDs

    • Modifications in JavaScript and CSS resources are recognized in the mix-manifest.json. Hash IDs linked with multiple files have been updated to reflect file content or version changes, indicating an effective update cycle over these files.

@Toreg87 Toreg87 closed this Oct 14, 2024
@Toreg87 Toreg87 force-pushed the fixes/api_asset_create_fmcs2 branch from b599582 to 0d35335 Compare October 14, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant