Skip to content

Conversation

@marcusmoore
Copy link
Collaborator

Description

#15648 updated dependencies and caused tests to start failing in CI. This PR updates brianium/paratest from v7.3.1 to v7.4.8 and fixes the issue.

I also added the sqlite files that are created when running parallel tests and using the sqlite driver to gitignore:
newly gitignored files

--

The exceptions we are seeing in CI:

Fatal error: Uncaught Illuminate\Contracts\Container\BindingResolutionException: Target [Illuminate\Contracts\Debug\ExceptionHandler] is not instantiable. in /home/runner/work/snipe-it/snipe-it/vendor/laravel/framework/src/Illuminate/Container/Container.php:1126
Stack trace:
#0 /home/runner/work/snipe-it/snipe-it/vendor/laravel/framework/src/Illuminate/Container/Container.php(921): Illuminate\Container\Container->notInstantiable()
#1 /home/runner/work/snipe-it/snipe-it/vendor/laravel/framework/src/Illuminate/Container/Container.php(795): Illuminate\Container\Container->build()
#2 /home/runner/work/snipe-it/snipe-it/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(961): Illuminate\Container\Container->resolve()
#3 /home/runner/work/snipe-it/snipe-it/vendor/laravel/framework/src/Illuminate/Container/Container.php(731): Illuminate\Foundation\Application->resolve()
#4 /home/runner/work/snipe-it/snipe-it/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(946): Illuminate\Container\Container->make()
#5 /home/runner/work/snipe-it/snipe-it/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php(288): Illuminate\Foundation\Application->make()
#6 /home/runner/work/snipe-it/snipe-it/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php(207): Illuminate\Foundation\Bootstrap\HandleExceptions->getExceptionHandler()
#7 /home/runner/work/snipe-it/snipe-it/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php(189): Illuminate\Foundation\Bootstrap\HandleExceptions->renderForConsole()
#8 /home/runner/work/snipe-it/snipe-it/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php(2[55](https://github.com/snipe/snipe-it/actions/runs/11273029665/job/31349173173#step:11:56)): Illuminate\Foundation\Bootstrap\HandleExceptions->handleException()
#9 [internal function]: Illuminate\Foundation\Bootstrap\HandleExceptions->Illuminate\Foundation\Bootstrap\{closure}()
#10 {main}
  thrown in /home/runner/work/snipe-it/snipe-it/vendor/laravel/framework/src/Illuminate/Container/Container.php on line 1126

Type of change

  • Dependencies

@marcusmoore marcusmoore requested a review from snipe as a code owner October 18, 2024 00:41
@what-the-diff
Copy link

what-the-diff bot commented Oct 18, 2024

PR Summary

  • Update to .gitignore file
    A new entry has been added to the .gitignore file. This means that any file that has a name following the pattern *.sqlite_* will now be automatically ignored by Git. This is typically done to prevent specific types of temporary or unnecessary files from being tracked and included in the repository, reducing clutter and maintaining the simplicity of the codebase.

@marcusmoore
Copy link
Collaborator Author

Ah...they dropped 8.1 support in v7.4.0. I'm going to close this and create another PR dropping --parallel from CI.

@marcusmoore marcusmoore deleted the dependencies/paratest branch October 18, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant