FIXED: Login button can disappear under some circumstances

[akemidx]

Description

The login button can disappear when the header color in Admin>Branding is set to white (#FFFFFF) since the button is set on a white background.
It appears on hover, and is still usable.
Some styling has been removed and the button will no longer take on the header color and thus will always be visible.

before

current button

Fixes # (26974)

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

visual test and test suite

Test Configuration:

• PHP version: 8.1
• OS version: Sonoma 14.6

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[what-the-diff]

PR Summary

• Elimination of Custom Styles for Button

  The unique styling previously set for the primary button, which determined its background and border color, has been discarded. This could potentially allow for a more consistent interface look, maintainable design, and increase overall user experience quality.

[snipe]

This doesn't account for the scenario where someone has a light header color, so you could end up with white text on a white header. We don't currently ask folks to set font colors, link colors, etc though, so I'm not really sure how to handle this properly (per our meeting a few weeks ago.)

[akemidx]

This doesn't account for the scenario where someone has a light header color, so you could end up with white text on a white header. We don't currently ask folks to set font colors, link colors, etc though, so I'm not really sure how to handle this properly (per our meeting a few weeks ago.)

correct, this does NOT fix the header color or header washing out. This ONLY fixes the login button disappearing while a user has a header color chosen to be white.

The logic being that, if a user logs out while having that white header, at LEAST they will have a normal login, to get back in and change that header back. Our login window is static in its coloring, EXCEPT for that login button, so this makes it completely standardized.