Skip to content

FIXED: Bulk Delete page not showing full information #15757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2024
Merged

FIXED: Bulk Delete page not showing full information #15757

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f108076
fixing bulk delete table
akemidx Oct 30, 2024
2f5e468
this fixes the assigned to piece
akemidx Nov 5, 2024
82c38a8
or statement for if/else
akemidx Nov 5, 2024
efeef5c
removing || parts of if else
akemidx Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions resources/views/hardware/bulk-delete.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,15 @@
<td>{{ $asset->id }}</td>
<td>{{ $asset->present()->name() }}</td>
<td>
@if ($asset->location)
@if ($asset->location_id)
Copy link
Member

@snipe snipe Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this line changed? There is a relationship ($asset->location) which is being checked for, which is generally better than just checking for the ID, since the ID could be invalid.

Copy link
Member Author

@akemidx akemidx Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, the two things we were checking against are the location_id and the rtd_location_id. these are the two values in the assets table when we looked for location. currently, we are ending up with blanks for the location of an asset on the bulk delete page, this is weird behavior, since it won't match the assets index page. since through deployedLocationFormatter we return the row.name off the row.id, and if not, then we pull the rtd_location.name from the rtd_location.id. its this if/else that we tried to parity.

Copy link
Member

@snipe snipe Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but if the location_id or rtd_location_id reference a non-existent location (bad data, etc), that will 500. We should be checking against the relations to make sure those locations actually exist in the database.

Copy link
Member Author

@akemidx akemidx Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

righto, i'll get to this on monday and get that switched over. ty for the explaination.

{{ $asset->location->name }}
@elseif($asset->rtd_location_id)
{{ $asset->defaultLoc->name }}
@endif
</td>
<td>

{{ $asset->assigned_to }}
@if ($asset->assignedTo)
{{ $asset->assignedTo->present()->name()}}
@if ($asset->assigned_to)
{{ $asset->assigned->present()->name() }}
@endif
</td>
</tr>
Expand Down
Loading