Fixed: Trans Choice in Unaccepted Asset Email #16237
Conversation
PR Summary
|
resources/lang/en-US/mail.php
Outdated
| @@ -88,7 +88,7 @@ | |||
| 'upcoming-audits' => 'There is :count asset that is coming up for audit within :threshold days.|There are :count assets that are coming up for audit within :threshold days.', | |||
| 'user' => 'User', | |||
| 'username' => 'Username', | |||
| 'unaccepted_asset_reminder' => 'You have Unaccepted Assets.', | |||
| 'unaccepted_asset_reminder' => 'You have Unaccepted Asset(s).', | |||
There was a problem hiding this comment.
This weeks awkward to me - I think we'd want to trans_choice the subject here as well
There was a problem hiding this comment.
So, yea, I figured that this would catch your attention.
I am unsure how to get that to actually work. The email text is in markdown, but the actual email title is built different. its running off a function public function envelope(): Envelope line 30 in UnacceptedAssetReminderMail.php
There is probably a pretty tricky way to get it to work tho...
| $this->count = $count; | ||
| $from = new Address(config('mail.from.address'), config('mail.from.name')); | ||
| $subject = trans_choice('mail.unaccepted_asset_reminder', $count); |
There was a problem hiding this comment.
I think $this->count = $count; should be removed and $count should be $this->count on line 34.
routes/web.php
Outdated
| Route::get('/mailable', function (){ | ||
| $checkout_info = []; | ||
| $acceptance = CheckoutAcceptance::first(); | ||
| //dd($acceptance); | ||
| $count = []; | ||
|
|
||
| $checkout_info['acceptance'] = $acceptance; | ||
|
|
||
| return new App\Mail\UnacceptedAssetReminderMail($checkout_info,2); | ||
| }); | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
This was for testing and needs to be removed.
|
EX of new subject line |
|
For clarity this changes the subject line for single items as well (from
|
Fixed an issue where the body of an email did not pluralize
itemswhen multiple items were unaccepted.