Refactors Low Inventory Alert Notification to Mailable #16444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusmoore
requested changes
Mar 6, 2025
Collaborator
marcusmoore
left a comment
marcusmoore
left a comment
There was a problem hiding this comment.
Looks good but one question about the AllowDynamicProperties attribute.
Can we delete App\Notifications\InventoryAlert in the PR as well?
Godmartinz
changed the title
Member
|
Can you remind me why we're using Mailable here? Notifications were the way we used to do these and I don't recall why we suddenly needed to change these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactors the low inventory alert notification to a mailable and adds tests too.