Skip to content

Conversation

@snipe
Copy link
Member

@snipe snipe commented Mar 12, 2025

Because Laravel assumes $user is the logged in user if one has not beed explicitly passed, the new user modal would pre-populate some information from the admin trying to create them.

Screenshot 2025-03-12 at 5 04 34 PM

This also adds some tests around that so we can make sure future Laravel upgrades do not change the expected outcome.

@what-the-diff
Copy link

what-the-diff bot commented Mar 12, 2025

PR Summary

  • Improved Modal Display Formatting
    We updated the method in which the system displays modals to make them more structured and readable to users. This has led to a smoother interaction experience with dialog boxes.

  • Enhanced Form Initialization
    We made changes to the name input fields in our user forms to retain input values even after resetting, which allows for less repetition and more efficient interaction with our system.

  • Optimized Default Input Handling
    We tweaked the handling of default input in the user name fields, so the system can better process potential user inputs.

  • Expanded Security Checks in Test Cases
    We've improved the security in modal views by ensuring user data (such as first and last names and email) is not visible. The enhanced testing guarantees that user privacy is sustained, making our software safer to use.

@snipe snipe requested review from marcusmoore and uberbrady March 12, 2025 17:31
Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this down and tried it on the checkout asset screen. Looks good to me.

@snipe snipe merged commit dbe78c3 into develop Mar 12, 2025
9 checks passed
@snipe snipe deleted the bug/sc-28671 branch March 12, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants