Skip to content

Conversation

@marcusmoore
Copy link
Collaborator

@marcusmoore marcusmoore commented Mar 12, 2025

THIS PR MAKES CHANGES TO THE ACTION LOG


This PR follows up a comment in #16489 where it was noticed we were logging consumable checkins when bulk deleting a user.

This PR stops that type of logging and purges the action log of existing entries for consumable checkins.

@what-the-diff
Copy link

what-the-diff bot commented Mar 12, 2025

PR Summary

  • Enhanced Efficiency by Removing Logging for Consumable Check-ins
    This update has taken away some functionality which wasn't necessary; specifically, a way of monitoring when items are logged out en masse. This reduces the amount of noise in our logs, making critical information easier to spot.

  • Cleaning Up Past Logs with a New Database Update
    We've created an operation that's going to go through past logs which contain unnecessary entries about consumables check-in, and remove them. This will ensure our logs from the past are clean and easier to refer to, uncluttered by data we no longer need.

  • Ensuring the New Behavior through Updated Tests
    Our testing suite has been adapted to reflect these changes. We'll be checking more actively that the detail about consumable check-ins are NOT appearing in our logs, which will assure consistency of this new change in the future.

@snipe snipe merged commit 9ad99c1 into grokability:develop Apr 19, 2025
9 checks passed
@marcusmoore marcusmoore deleted the bug/sc-28675 branch April 21, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants