Skip to content

Conversation

@Godmartinz
Copy link
Member

@Godmartinz Godmartinz commented Mar 12, 2025

This removes all deprecated MS Teams integration tests and check in and check out methods. Webhooks were deprecated Jan 31st, 2025.

Updates the warning messages to be past tense if an old webhook URL is still stored:
image
image

Also, a warning will be returned before trying and failing to send the notification, item will still be checked in/out though:
image

@Godmartinz Godmartinz requested a review from snipe as a code owner March 12, 2025 21:12
@Godmartinz Godmartinz requested review from marcusmoore and snipe and removed request for snipe March 12, 2025 21:12
@what-the-diff
Copy link

what-the-diff bot commented Mar 12, 2025

PR Summary

  • Updated Deprecation Message for Microsoft Teams Webhook
    The system message concerning Microsoft Teams webhook's status has been updated to clarify that it's already deprecated.
  • Added Checks to Prevent Webhook Notifications in Specific Cases
    In our CheckoutableListener.php file, a check has been put in place prohibiting webhook notifications when the webhook endpoint includes 'workflows'.
  • Modified Warning in SlackSettingsForm.php to Reflect Current Status
    The warning message in the SlackSettingsForm.php file has been revised to indicate the latest deprecation status of the Microsoft Teams webhook.
  • Removed Deprecated Webhook Logic from Notification Classes
    Obsolete logic related to webhooks has been removed from six notification classes including CheckinAccessoryNotification.php, CheckoutAccessoryNotification.php, and others.
  • Eliminated Checks for Microsoft Teams Channel Notification Setup
    Removed outdated checks for the setup of Microsoft Teams channel notifications from several notification classes. This streamlines the notification system since these checks are no longer needed.

@Godmartinz Godmartinz marked this pull request as draft March 12, 2025 21:19
@Godmartinz Godmartinz marked this pull request as ready for review March 12, 2025 22:49
@Godmartinz
Copy link
Member Author

looking at failing tests.

@uberbrady
Copy link
Member

Microsoft's should be possessive. Documentation should not be capitalized. When making a URL, the period at the end of the sentence should not be part of the URL.

If the flagged alert-listing at the top is disabled behind "turn off low-inventory alerts", will this still show? If not, then maybe we should change that?

@uberbrady
Copy link
Member

Or, if the only way that we show the 'flag' icon when low inventory alerts and we only do that in the layout, could we just change the layout?

@uberbrady
Copy link
Member

@snipe worries that the webhook notification might only need to be visible for superadmins, not other people who might see low inventory alerts...

@Godmartinz
Copy link
Member Author

Closing this for now, since Team webhooks wont be deprecated til the end of the year now.

@Godmartinz Godmartinz closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants