Skip to content

Conversation

@snipe
Copy link
Member

@snipe snipe commented Mar 12, 2025

(On mobile, so I can’t do it normally)

@what-the-diff
Copy link

what-the-diff bot commented Mar 12, 2025

PR Summary

  • Modification of asset_maintenance_time calculation
    The computation method of asset_maintenance_time in several controllers has been changed to ensure it returns whole number values - this enhances precision.

  • Update of transformAsset method
    The method transformAsset in AssetsTransformer has been adjusted to align with the new way of handling eol as whole numbers.

  • Tweaked next_audit_days computation
    The calculation method of next_audit_days in Actionlog has been refined to produce whole number days. This clarifies the time till next audit.

  • Test assertions adjustment
    Multiple test files have been modified to ensure time comparisons align with our new whole-number approach, increasing accuracy of our tests.

  • New tests for Asset Maintenance
    New tests have been added to verify the creation and updating of asset maintenance records, improving the reliability of our feature.

  • Refactoring of upcoming-audits notification view
    The upcoming-audits notification layout has been refactored. Now, the difference in time (diff) for audits is displayed as whole numbers, making readability easier.

@snipe snipe changed the title Nerve develop into master Merge develop into master Mar 12, 2025
@snipe snipe merged commit eb9cfba into master Mar 12, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants