-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Logging Audit on Checkin/out #16679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akemidx
wants to merge
13
commits into
grokability:develop
Choose a base branch
from
akemidx:feature/sc-27328-new
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Logging Audit on Checkin/out #16679
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
be0fdb3
beginning of audit on checkin/out
akemidx 26aa3ee
less overthinking
akemidx 0b288ed
checkboxes on the checkin/out screen
akemidx 02357a8
operational stuffhoohasdss
akemidx 1943bcd
removing unneededdnessnesneed
akemidx 6617fa9
requested variable changes
akemidx cc686b1
forgot the other bits
akemidx 2b54fbb
trying to avoid a 403 when checking if the log_audit is chosen
akemidx 802f03e
fixing white space
akemidx 6f2d314
changing Gate location
akemidx 4cad217
js script
akemidx e9be4ef
js script
akemidx ea94123
removing unneeded blocks
akemidx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This phrasing seems a little clunky to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, but words are not my strong suit.
However, this seems clunky since at the END after 'this' it will say checkin or checkout
example:
{{ trans('admin/settings/general.log_audit_help_text') . " " . trans('general.checkin') . "." }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my example in the PR review comment. I suggested different phrasing altogether :)