Skip to content

Conversation

@CloCkWeRX
Copy link
Contributor

@CloCkWeRX CloCkWeRX commented Apr 18, 2025

https://github.com/codespell-project/codespell is a useful linter. While this is a widespread change, I did hand apply these. If wanted, can break this up into smaller chunks.

To using the tooling; assuming you have python - add via pip install codespell and run as codespell

Optional extras:

  • Precommit hook
  • GIthub actions

@CloCkWeRX CloCkWeRX marked this pull request as ready for review April 18, 2025 00:18
Add PHPCS and correct app/Importer/ for PSR-12 (errors only)
@CloCkWeRX CloCkWeRX closed this Apr 18, 2025
@snipe snipe reopened this Apr 18, 2025
@snipe
Copy link
Member

snipe commented Apr 18, 2025

Is there a particular advantage to codespell over other PHP-based code quality tooling?

@CloCkWeRX CloCkWeRX closed this Apr 18, 2025
@CloCkWeRX CloCkWeRX deleted the codespell branch April 18, 2025 15:56
@snipe
Copy link
Member

snipe commented Apr 18, 2025

I’m not sure why you’re taking your toys and going home. I simply asked for some discussions and consideration for the maintainers and the project. A lot of your changes are good, and we’ve been happy to take them, but adding features that haven’t been discussed previously does put a burden on us. We can’t take every feature, and not every feature makes sense (for example, geolocating on location, when the most common use case is one where a location gets created when the user isn’t physically there.)

I don’t know why you’re taking this so personally. I’ve accepted most of your PRs, I just prefer a discussion to happen around new features, which I don’t think is unreasonable.

If you’d like to discuss this further, you can reach me at [email protected]. Your work is good, and we’ve appreciated it, we just need a little more conversation so we can share with you the direction we’re going, the things we’re working on, and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants