Skip to content

Check for Printing Location Tags for Assets without Locations #16796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spencerrlongg wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Check for Printing Location Tags for Assets without Locations #16796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2591d0d
add condition for if asset doesn't have location id, needs testing
spencerrlongg Apr 23, 2025
271276e
put check at top, add translation
spencerrlongg Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/View/Label.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,15 @@ public function render(callable $callback = null)
$assets = $this->data->get('assets');
$offset = $this->data->get('offset');

// if you're printing location target tags, make sure the assets have locations if not redirect with error
if (($settings->label2_2d_target == 'location')) {
foreach ($assets as $asset) {
if (!$asset->location_id) {
return redirect()->back()->with('error', trans('admin/labels/message.asset_no_location'));
}
}
}


// If disabled, pass to legacy view
if ((!$settings->label2_enable)) {
Expand Down
2 changes: 2 additions & 0 deletions resources/lang/en-US/admin/labels/message.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
'invalid_return_type' => 'Invalid type returned from :name. Expected :expected, got :actual.',
'invalid_return_value' => 'Invalid value returned from :name. Expected :expected, got :actual.',

'asset_no_location' => 'You have selected to target your labels to locations, and one or more of the assets\' tags you\'re trying to print do not have a location.',

'does_not_exist' => 'Label does not exist',

];
Loading