Skip to content

WIP: Include "child" assets in inventory email and other views #16842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

marcusmoore
Copy link
Collaborator

Here is the set up for the description that follows:

  • asset-001, asset-002, asset-003, and asset-004 are checked out directly to the user
  • asset-001-01 is checked out to asset-001
  • asset-003-01 is checked out to asset-003
  • asset-003-02 is checked out to asset-003
  • "Show assets assigned to assets" is enabled in settings
    image

As pointed out in #16811, the email that is sent when clicking the "Email list of all Assigned" button does not include "child" assets (assets that are checked out to the assets checked out to the given user):
image

But they are included in the view for "Printing All Assigned":
image

Helpfully they are numbered x.x

This PR addresses that by including the child assets in the email along with the x.x numbering:
image


In addition, I noticed that child assets were missing when viewing a user's assets (/users/1#asset) or your own asset's (/account/view-assets#assets).

I've add this to your viewing your own assets:
Before: image

After:
image

  • And the last thing to do is add it to viewing a user's assets:
    Before:
    image

fixes #16811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant