-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
WIP: Include "child" assets in inventory email and other views #16842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
marcusmoore
wants to merge
18
commits into
grokability:develop
Choose a base branch
from
marcusmoore:fixes/inventory
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the set up for the description that follows:
As pointed out in #16811, the email that is sent when clicking the "Email list of all Assigned" button does not include "child" assets (assets that are checked out to the assets checked out to the given user):

But they are included in the view for "Printing All Assigned":

This PR addresses that by including the child assets in the email along with the

x.x
numbering:In addition, I noticed that child assets were missing when viewing a user's assets (
/users/1#asset
) or your own asset's (/account/view-assets#assets
).I've add this to your viewing your own assets:
Before:
After:

Before:
fixes #16811