Generic tape #16857
Merged
Generic tape #16857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for this! Can you rebase this PR? I don't think you actually changed 52 files. |
realchrisolin
force-pushed
the
generic_tape
branch
from
d83f762 to
541db78
Compare
Contributor
Author
|
wasn't able to rebase without conflicts, used |
realchrisolin
force-pushed
the
generic_tape
branch
from
541db78 to
9c1e29d
Compare
Member
|
This is still showing 52 files changed, unfortunately - and one of the files you didn't change (the general settings blade) would cause a regression. |
Contributor
Author
|
I'm not sure why this is happening. I'm under the impression rebasing off develop should have fast-forwarded this branch (master) and applied my changes on top. The only other solution I can think of is to check out develop, cherry pick my changes on top, then overwrite this branch with that. |
realchrisolin
force-pushed
the
generic_tape
branch
from
9c1e29d to
248a05a
Compare
Contributor
Author
|
That seems to have worked, sorry about that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing label classes are for specific model printers that are priced outside of the average person using Snipe-IT for personal uses (e.g. bin storage), however there are affordable "generic" Bluetooth label printers available on Amazon and other e-commerce stores. This PR adds the Labels/Tapes/Generic namespace, a GenericTape abstract class, and additional classes that add support for generic 53mm width and 0.59in continuous roll thermal paper printers.
I have another commit in to works to add to this PR that adds another 53mm label that is landscape oriented. The current label (Continuous_53mm_A) is portrait oriented.