Fixed #16863 - better handle custom fields validation when unique but not required #16895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: snipe <[email protected]>
snipe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the redirect if data is not complete (or the validation rules have changed since the asset was created/last updated), it was incorrectly redirecting to the edit asset page if the field was marked as unique, even if it was already unique. This is because the
UniqueUndeletedTraitand therefore theunique_undeletedvalidator could not see the present model, so the existing record couldn't exclude its own ID from validation.Thanks for the rubber ducking @marcusmoore and @uberbrady! 🫶🏻