Handle settings not being available in full name accessor #16900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an exception being thrown while going through the application set up workflow. Oddly enough it was sporadic and at times I was able to successfully set up the application without hitting it.
From the best I can tell the problem stems from the chunk below:
snipe-it/app/Http/Controllers/SettingsController.php
Lines 201 to 203 in 407962d
The user listener was firing on the
->save()line and somewhere along the line$user->full_namewas being called before the settings were saved.I haven't had a chance to full test thing to make sure there aren't any side-effects I'm not considering but here it is if other people report set up issues.