A quick check to make sure that webhooks still fire when email is off #16942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think @marcusmoore 's fix #16932 is more likely to be the better fix, going forward, since he includes tests and I think untangles some of the logic a little more cleanly. But this is short, and seems to help for now.
I was able to configure my development workstation to turn off global notifications, and turn off notifications in the category in question, and then I stopped getting webhooks, even though the UI says that I should get one.
When I applied this fix, then I got the webhook notifications again.
So I think it's a safe interim step until we can get Marcus's more permanent fix.