Gracefully handle error when editing of soft deleted users #16946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
I'd say so, at least for now. No one has complained about not being able to edit deleted users in the past. |
Collaborator
Author
|
@snipe updated. Check the updated PR description for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a 500 would be thrown if a soft-deleted user is edited via the UI.
@snipe I noticed the API doesn't allow modifying users that are soft deleted and the UI shows the edit button disabled but you can manually get to the route.
✅ Should I include not allowing the edit page to show for soft deleted users?
This is added so attempting to manually view the route redirects back to the user show page with the existing helpful message at the top: